Date: Fri, 9 Sep 1994 20:05:32 +0100 (BST) From: paul@isl.cf.ac.uk (Paul Richards) To: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes) Cc: paul@isl.cf.ac.uk, paul@freefall.cdrom.com, ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-libexec@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, jkh@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com Subject: Re: cvs commit: src/libexec Makefile Message-ID: <199409091905.UAA07408@isl-gate.elsy.cf.ac.uk> In-Reply-To: <199409091813.LAA11979@gndrsh.aac.dev.com> from "Rodney W. Grimes" at Sep 9, 94 11:13:51 am
next in thread | previous in thread | raw e-mail | index | archive | help
In reply to Rodney W. Grimes who said > > Now, onto another thing about this particual commit and why a review should > have been done. You set up gnats, great, wonderfull THANKS!! But no one, > nata, zippo, in -core, or else where has ever even done a test filling of > a bug report. Nor is it currently possible for anyone to have a working > send-pr even on a system build 4 hours ago from -current. This is just completely and utterly untrue. If you're going to make criticisms I suggest you get your facts straight. I have submitted numerous reports to ensure it's all working. If you did not see any of these then I would like to know why since that is possibly a bug. You won't find any of the test reports in the database because I reset everything since I didn't see any value in having them clutter it up. > > Currently send-pr is going to fail install on anyones box who enables it > in gnu/usr.bin/Makefile (or did you do that alread): > skyrsh:rgrimes {116} make install > install -c -o bin -g bin -m 555 /usr/src/gnu/usr.bin/send-pr/send-pr /usr/bin/send-pr > install: /usr/src/gnu/usr.bin/send-pr/send-pr: No such file or directory > *** Error code 1 > > Stop. > skyrsh:rgrimes {117} I haven't enabled send-pr in the /usr/src/gnu/Makefile, I will do that immediately. This was an oversight, I thought I'd done that already. I don't know what you've done but it works fine on my box. isl-gate:gnu/usr.bin# make ===> send-pr sed -e 's,@DATADIR@,/etc,g' -e 's/@DEFAULT_RELEASE@/`uname -rsm`/g' send-pr.sh > send-pr sed -e 's,@DATADIR@,/etc,g' -e 's/@DEFAULT_RELEASE@/`uname -rsm`/g' send-pr-el.in > send-pr.el sed -e 's,@BINDIR@,/usr/bin,g' install-sid.sh > install-sid isl-gate:gnu/usr.bin# make install ===> send-pr install -c -o bin -g bin -m 555 /FreeBSD-2.0/src/gnu/usr.bin/send-pr/send-pr /usr/bin/send-pr install -c -o bin -g bin -m 0644 /FreeBSD-2.0/src/gnu/usr.bin/send-pr/categories /etc/gnats/freefall sh /FreeBSD-2.0/src/gnu/usr.bin/send-pr/install-sid current-users install-sid: `current-users' is now the default submitter ID for send-pr (cd /FreeBSD-2.0/src/gnu/usr.bin/send-pr; install -c -o bin -g bin -m 444 send-pr.1 /usr/share/man/man1) > > It needs an update to etc/mtree before it can install. I have made the necessary changes to the mtree templates. send-pr is only going to work if you have a 2.0 system. We haven't released any upgrade intructions yet but I assume they're going to include running mtree. On a correctly setup 2.0 system send-pr will work fine. > > The previos user base does have some knowledge of and occasionally does use > the old bugfiller. In 2.0 this is now just going to dis appear with no > pointer to the new tool. I suggest you add a MLINKS= bugfiler send-pr or > is that send-pr bugfiler. I have posted a detailed explanation of send-pr to -current who are the only people who should be running 2.0 for the moment. I am continuing to look at the most effective way to get the userbase using send-pr as the user base gets broadened out. It wouldn't be bugfiler anything since that's what you run on the server to log the reports. I don't want to link sendbug to send-pr since I want people to be aware that we've changed the mechanism. In addition, sendbug will still be used on pre-2.0 systems since send-pr just doesn't exist on them. The whole issue is rather irrelevant since no-ones actually submitting reports using sendbug anyway and I'm going to actively encourage the submission of reports from now on so I'll be making a lot of noise about send-pr. > > If you had submitted this change for review, these facts would have been > uncovered before the commit and possible have saved me the above debug. > The only fact that needed to be uncovered was that I hadn't enabled send-pr in the Makefile. The rest of the criticisms are inaccurate. -- Paul Richards, FreeBSD core team member. Intelligent Systems Laboratory, ELSYM ,University of Wales, College Cardiff Internet: paul@isl.cf.ac.uk, JANET(UK): RICHARDSDP@CARDIFF.AC.UK
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199409091905.UAA07408>