From owner-freebsd-acpi@FreeBSD.ORG Fri Sep 21 11:03:08 2007 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0833216A41A; Fri, 21 Sep 2007 11:03:08 +0000 (UTC) (envelope-from cristi@net.utcluj.ro) Received: from bavaria.utcluj.ro (unknown [IPv6:2001:b30:5000:2:20e:cff:fe4b:ca01]) by mx1.freebsd.org (Postfix) with ESMTP id 71FEF13C447; Fri, 21 Sep 2007 11:03:07 +0000 (UTC) (envelope-from cristi@net.utcluj.ro) Received: from localhost (localhost [127.0.0.1]) by bavaria.utcluj.ro (Postfix) with ESMTP id 2E13150899; Fri, 21 Sep 2007 14:03:06 +0300 (EEST) X-Virus-Scanned: by the daemon playing with your mail on local.mail.utcluj.ro Received: from bavaria.utcluj.ro ([127.0.0.1]) by localhost (bavaria.utcluj.ro [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fiHkHJdF6R8x; Fri, 21 Sep 2007 14:03:01 +0300 (EEST) Received: from [193.226.5.46] (hades.utcluj.ro [193.226.5.46]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by bavaria.utcluj.ro (Postfix) with ESMTP id 4FFAD5089F; Fri, 21 Sep 2007 14:03:01 +0300 (EEST) Message-ID: <46F3A4E4.5030702@net.utcluj.ro> Date: Fri, 21 Sep 2007 14:03:00 +0300 From: Cristian KLEIN User-Agent: Thunderbird 1.5.0.13 (X11/20070824) MIME-Version: 1.0 To: Jung-uk Kim References: <200709181516.11207.jkim@FreeBSD.org> <46F041BC.6070604@net.utcluj.ro> <200709181734.57392.jkim@FreeBSD.org> In-Reply-To: <200709181734.57392.jkim@FreeBSD.org> X-Enigmail-Version: 0.94.2.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-acpi@FreeBSD.org, freebsd-current@FreeBSD.org Subject: Re: [PATCH] OsdSynch.c modernization X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2007 11:03:08 -0000 Jung-uk Kim wrote: > On Tuesday 18 September 2007 05:23 pm, Cristian KLEIN wrote: >> Jung-uk Kim wrote: >>> I have rewritten sys/dev/acpica/Osd/OsdSynch.c to match the >>> modern ACPI-CA and -CURRENT: >>> >>> http://people.freebsd.org/~jkim/acpica/OsdSynch.diff >>> >>> Major changes are: >>> >>> 1. Semaphore is reimplemented with convar(9) instead of mutex(9). >>> >>> 2. Semaphore with ACPI_WAIT_FOREVER option actually waits forever >>> now. >>> >>> 3. Obsolete and/or hidden debugging knobs and macros are removed. >>> >>> 4. ACPI-CA introduced AcpiOs*Mutex() to complement >>> AcpiOs*Semaphore(): >>> >>> http://bugzilla.kernel.org/show_bug.cgi?id=6634 >>> >>> These functions are implemented and turned on by default. >>> >>> 5. Spinlock is reimplemented with sx lock and more closely >>> implements the intended behaviour (e.g., save/restore >>> interrupts). >>> >>> It is orthogonal to Nate's effort of rewriting acpi_ec.c but I'd >>> like get more feedback *with* his last patch (revision D) because >>> his patch will be committed sooner or later. ;-) >>> >>> Please test/review and let us know if there is any regression or >>> not. >> Sorry for not being able to test the patch. May I assume this will >> fix: >> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=114113 >> http://www.freebsd.org/cgi/query-pr.cgi?pr=114649 > > I believe my patch AND Nate's patch will fix the problem. Hi, I tested your patch and it works flawless. However, before applying your patch, the "recursive lock on non-recursive mutex" did not occur either.