Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Sep 2021 11:56:50 +0800
From:      Po-Chuan Hsieh <sunpoet@freebsd.org>
To:        Bryan Drewery <bdrewery@freebsd.org>
Cc:        Po-Chuan Hsieh <sunpoet@freebsd.org>, ports-committers@freebsd.org,  dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org,  Colin Percival <cperciva@freebsd.org>
Subject:   Re: git: 915dbfaa562e - main - */*hyphen: Avoid using %% in Makefile
Message-ID:  <CAMHz58Q0s8Ap9J54rj2R-PTUScwxSxXsbHm7nOzWwCMvSS9gBQ@mail.gmail.com>
In-Reply-To: <f625946d-63ce-b1b4-d8a0-bda60e990b93@FreeBSD.org>
References:  <202109190608.18J68vCU055225@gitrepo.freebsd.org> <f625946d-63ce-b1b4-d8a0-bda60e990b93@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 21, 2021 at 8:02 AM Bryan Drewery <bdrewery@freebsd.org> wrote:

> On 9/18/2021 11:08 PM, Po-Chuan Hsieh wrote:
> > The branch main has been updated by sunpoet:
> >
> > URL:
> https://cgit.FreeBSD.org/ports/commit/?id=915dbfaa562e20c8402d3873f8bfbf07899f9f8a
> >
> > commit 915dbfaa562e20c8402d3873f8bfbf07899f9f8a
> > Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> > AuthorDate: 2021-09-19 05:31:28 +0000
> > Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> > CommitDate: 2021-09-19 06:00:48 +0000
> >
> >     */*hyphen: Avoid using %% in Makefile
> >
> >     Use ${DATAIDR} instead of %%DATADIR%%
> > ---
> >  german/hyphen/Makefile       |  4 ++--
> >  german/hyphen/Makefile       | 33 +++++++++++++++++++++++++++++++++
> >  hungarian/hyphen/Makefile    |  2 +-
> >  hungarian/hyphen/Makefile    | 25 +++++++++++++++++++++++++
> >  polish/hyphen/Makefile       |  2 +-
> >  polish/hyphen/Makefile       | 25 +++++++++++++++++++++++++
> >  portuguese/hyphen/Makefile   |  4 ++--
> >  portuguese/hyphen/Makefile   | 27 +++++++++++++++++++++++++++
> >  russian/hyphen/Makefile      |  4 ++--
> >  russian/hyphen/Makefile      | 27 +++++++++++++++++++++++++++
> >  textproc/bg-hyphen/Makefile  |  2 +-
> >  textproc/bg-hyphen/Makefile  | 29 +++++++++++++++++++++++++++++
> >  textproc/cs-hyphen/Makefile  |  2 +-
> >  textproc/cs-hyphen/Makefile  | 25 +++++++++++++++++++++++++
> >  textproc/el-hyphen/Makefile  |  4 ++--
> >  textproc/el-hyphen/Makefile  | 28 ++++++++++++++++++++++++++++
> >  textproc/es-hyphen/Makefile  |  4 ++--
> >  textproc/es-hyphen/Makefile  | 43
> +++++++++++++++++++++++++++++++++++++++++++
> >  textproc/hyphen/Makefile     |  4 ++--
> >  textproc/hyphen/Makefile     | 41
> +++++++++++++++++++++++++++++++++++++++++
> >  textproc/id-hyphen/Makefile  |  2 +-
> >  textproc/id-hyphen/Makefile  | 26 ++++++++++++++++++++++++++
> >  textproc/is-hyphen/Makefile  |  2 +-
> >  textproc/is-hyphen/Makefile  | 26 ++++++++++++++++++++++++++
> >  textproc/it-hyphen/Makefile  |  4 ++--
> >  textproc/it-hyphen/Makefile  | 28 ++++++++++++++++++++++++++++
> >  textproc/lt-hyphen/Makefile  |  2 +-
> >  textproc/lt-hyphen/Makefile  | 26 ++++++++++++++++++++++++++
> >  textproc/nl-hyphen/Makefile  |  2 +-
> >  textproc/nl-hyphen/Makefile  | 26 ++++++++++++++++++++++++++
> >  textproc/ro-hyphen/Makefile  |  2 +-
> >  textproc/ro-hyphen/Makefile  | 26 ++++++++++++++++++++++++++
> >  textproc/sk-hyphen/Makefile  |  2 +-
> >  textproc/sk-hyphen/Makefile  | 26 ++++++++++++++++++++++++++
> >  textproc/sl-hyphen/Makefile  |  2 +-
> >  textproc/sl-hyphen/Makefile  | 26 ++++++++++++++++++++++++++
> >  ukrainian/hyphen/Makefile    |  2 +-
> >  ukrainian/hyphen/Makefile    | 25 +++++++++++++++++++++++++
>
> This created a bunch of 'Makefile ' files with the trailing space.
> Surely that was a mistake and not intended?
>
> cperciva@ reports it breaks portsnap.
>
>
Thanks for letting me know.
Those backup files ("Makefile ") are removed.
I made in-place replacement with sed -i '' but somehow an unintended space
was added.


> --
> Regards,
> Bryan Drewery
>
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58Q0s8Ap9J54rj2R-PTUScwxSxXsbHm7nOzWwCMvSS9gBQ>