From owner-freebsd-apache@FreeBSD.ORG  Tue Mar 29 22:03:36 2011
Return-Path: <owner-freebsd-apache@FreeBSD.ORG>
Delivered-To: apache@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 565831065670;
	Tue, 29 Mar 2011 22:03:36 +0000 (UTC)
	(envelope-from ohauer@FreeBSD.org)
Received: from u18-124.dslaccess.de (unknown [194.231.39.124])
	by mx1.freebsd.org (Postfix) with ESMTP id 04E0E8FC13;
	Tue, 29 Mar 2011 22:03:36 +0000 (UTC)
Received: from [172.20.1.100] (unknown [172.20.1.100])
	by u18-124.dslaccess.de (Postfix) with ESMTPSA id 638A120786;
	Wed, 30 Mar 2011 00:03:32 +0200 (CEST)
Message-ID: <4D925746.8000104@FreeBSD.org>
Date: Wed, 30 Mar 2011 00:03:50 +0200
From: Olli Hauer <ohauer@FreeBSD.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9
MIME-Version: 1.0
To: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
References: <4D924088.20206@gmx.de> <4D924868.3020707@p6m7g8.com>
	<4D92503F.4020004@FreeBSD.org> <4D925470.1060508@p6m7g8.com>
In-Reply-To: <4D925470.1060508@p6m7g8.com>
X-Enigmail-Version: 1.1.1
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Cc: ohauer@FreeBSD.org, "Philip M. Gollucci" <pgollucci@FreeBSD.org>,
	apache@FreeBSD.org
Subject: Re: need some hint about how to handle the following issue  (new
 bsd.apache.mk)
X-BeenThere: freebsd-apache@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: ohauer@FreeBSD.org
List-Id: Support of apache-related ports  <freebsd-apache.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-apache>, 
	<mailto:freebsd-apache-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-apache>
List-Post: <mailto:freebsd-apache@freebsd.org>
List-Help: <mailto:freebsd-apache-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-apache>,
	<mailto:freebsd-apache-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Mar 2011 22:03:36 -0000

On 2011-03-29 23:51, Philip M. Gollucci wrote:
> On 03/29/11 21:33, Olli Hauer wrote:
>> http://people.freebsd.org/~ohauer/diffs/Mk/PR_147009_ports__Mk__bsd.apache.mk_2011-03-29_01.diff
>> http://people.freebsd.org/~ohauer/diffs/Mk/PR_147009_bsd.apache.mk_2011-03-29_01.txt
> 
>> @Philip
>> do you know the reason for the following expression
>> at top of bsd.apache.mk
>>
>>> .if !defined(Apache_Pre_Include) || defined(PORT_IS_MODULE)
> 
> USE_APACHE= common22 is reserved specifically so that www/apache* ports
> can use Mk/bsd.apache.mk themselves.  Note how *zope* ports get this wrong.
> 
> When USE_APACHE= commmonXX AP_PORT_IS_SERVER is true meaning your in
> www/apacheX* ports.  When AP_PORT_IS_MODULE is true you're got
> USE_APACHE=XX and you're in anything not www/apacheXX.  Usually www/mod_*.
> 
> See also the layout for www/apache22 and www/apache22-$mpm-mpm which
> re-uses the commonXX.
> 

The use of commonXX is clear, maybe the following explains
better why I ask.

-.if !defined(Apache_Pre_Include) || defined(PORT_IS_MODULE)
+.if !defined(Apache_Pre_Include) || defined(AP_PORT_IS_MODULE)