From owner-cvs-all@FreeBSD.ORG Sun Nov 16 17:53:11 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F19E816A4CE; Sun, 16 Nov 2003 17:53:11 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id CAFFD43FE0; Sun, 16 Nov 2003 17:53:10 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.9p2/8.12.9) with ESMTP id hAH1r9eG032457; Sun, 16 Nov 2003 18:53:09 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 16 Nov 2003 18:52:27 -0700 (MST) Message-Id: <20031116.185227.72975859.imp@bsdimp.com> To: bms@spc.org From: "M. Warner Losh" In-Reply-To: <20031117012300.GA81780@saboteur.dek.spc.org> References: <200311162233.hAGMXgIj025490@repoman.freebsd.org> <20031116.153608.24272682.imp@bsdimp.com> <20031117012300.GA81780@saboteur.dek.spc.org> X-Mailer: Mew version 2.1 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/idt idt.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Nov 2003 01:53:12 -0000 In message: <20031117012300.GA81780@saboteur.dek.spc.org> Bruce M Simpson writes: : On Sun, Nov 16, 2003 at 03:36:08PM -0700, M. Warner Losh wrote: : > In message: <200311162233.hAGMXgIj025490@repoman.freebsd.org> : > Warner Losh writes: : > : Gross kludge: : > : > Others are welcome to find better ways to fix this. The real fix is : > to fix the driver to not require 2048 byte mbufs. : : I've looked at differences between pdq (DEC FDDI Controller) and idt(4). : It seems pdq does the right thing by specifying that it wants its buffers : to be 2048 bytes, using MCLGET() to ask for the cluster after the mbuf, : then using busdma to allocate the 2048 byte buffer. Don't let me stop you from fixing the driver or removing the test if the driver already has been fixed! Thanks for grunting out the details. It is much appreciated. Warner