From owner-svn-src-head@freebsd.org Sun Aug 7 23:59:38 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00A1DBB0AE0; Sun, 7 Aug 2016 23:59:38 +0000 (UTC) (envelope-from bms@fastmail.net) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CA56211F1; Sun, 7 Aug 2016 23:59:37 +0000 (UTC) (envelope-from bms@fastmail.net) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 4116320217; Sun, 7 Aug 2016 19:59:36 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute2.internal (MEProxy); Sun, 07 Aug 2016 19:59:36 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.net; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=iPrj1CJasb0lrDrS2nNpqrBEIDA=; b=Gh/Bg1 yuJtQ/KlD6cxW/tKa2jk0pKJD+k4ARen7YHQqw6pOgPWeRZ5/d4PCZWNHqQRc7EX o4RKOvynrzp8m362yquUrHdCcDFz0e4SmcY5+HPNgNIkQQ3ACv0+uS9Et+pcv0+S NCq4/4aLBnff4iG9WHCep2vBsTUac0U7EiWKE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=iPrj1CJasb0lrDr S2nNpqrBEIDA=; b=eFybnineg9/Y0QFK+lWXzKYN7aGz3eECl5p6Ks5QmaevCsh YBAd7IbXNJYQtQEuTfgSGGVRIqoYCVw5Bywa58t6U9WVXJAn1xNjvx2xl1XFcuJ0 kFD/vtS2SBgnRI9JjXduEDQhKidEDkOwOr7t5XvSYBKIifXkHjhcT0+8+4Sg= X-Sasl-enc: beaUMMjeWqyRC9WVC28hGkyOAs5/BqjalX9J5yqKNBmJ 1470614375 Received: from pion.local (5751ac42.skybroadband.com [87.81.172.66]) by mail.messagingengine.com (Postfix) with ESMTPA id 1D2CCF2985; Sun, 7 Aug 2016 19:59:34 -0400 (EDT) Subject: Re: svn commit: r303811 - in head/sys: net net80211 To: Peter Jeremy , Hans Petter Selasky References: <201608070348.u773mXXt030939@repo.freebsd.org> <46183559-343f-401b-6471-3822e3383a50@selasky.org> <20160807192333.GA79784@server.rulingia.com> Cc: Adrian Chadd , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Bruce Simpson Message-ID: <32531e89-85fa-6012-6a3e-1e6a42843dc0@fastmail.net> Date: Mon, 8 Aug 2016 00:59:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160807192333.GA79784@server.rulingia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Aug 2016 23:59:38 -0000 On 07/08/16 20:23, Peter Jeremy wrote: >> On 08/07/16 05:48, Adrian Chadd wrote: >>> +#define ETHER_IS_BROADCAST(addr) \ ... > IMHO, Adrian's code is clearer and micro-optimisations like this belong > in the complier, not the code. *cough* *cough* 2007 wants its patch back. https://people.freebsd.org/~bms/dump/old/latest-8021p.diff The whole point of using bcmp() was to allow it to be inlined by the compiler for the target arch, rather than forcing it to play guessing games with (lowest-common-denominator machine-word-size) integer accesses. ETHER_IS_MULTICAST(), by contrast, only needs to check a single bit in the 48-bit MAC.