From owner-p4-projects@FreeBSD.ORG Tue Sep 2 20:33:17 2003 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 2F3B616A4C1; Tue, 2 Sep 2003 20:33:17 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0DAD16A4BF for ; Tue, 2 Sep 2003 20:33:16 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB5FD43F93 for ; Tue, 2 Sep 2003 20:33:15 -0700 (PDT) (envelope-from marcel@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h833XF0U037634 for ; Tue, 2 Sep 2003 20:33:15 -0700 (PDT) (envelope-from marcel@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h833XFYh037631 for perforce@freebsd.org; Tue, 2 Sep 2003 20:33:15 -0700 (PDT) Date: Tue, 2 Sep 2003 20:33:15 -0700 (PDT) Message-Id: <200309030333.h833XFYh037631@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to marcel@freebsd.org using -f From: Marcel Moolenaar To: Perforce Change Reviews Subject: PERFORCE change 37416 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2003 03:33:17 -0000 http://perforce.freebsd.org/chv.cgi?CH=37416 Change 37416 by marcel@marcel_nfs on 2003/09/02 20:33:09 o Remove inclusion of . It was needed for uart_debug(), which got axed yesterday. o Remove sc_xonxoff, which got added yesterday. We're not going to support XON/XOFF flow control with hardware support. It's way too complicated to do it right and we already have the support in the tty layer. o Replace sc_rtscts with sc_hwiflow and sc_hwoflow. We'd like to take advantage of hardware flow control, even if only input or output flow control works for us. If we have a single flag, then it's a both or neither situation. Also, since we seperate flags for input and output flow control in the termios structure, it makes sense to keep them seperated as long as possible. Affected files ... .. //depot/projects/uart/dev/uart/uart_bus.h#24 edit Differences ... ==== //depot/projects/uart/dev/uart/uart_bus.h#24 (text+ko) ==== @@ -29,8 +29,6 @@ #ifndef _DEV_UART_BUS_H_ #define _DEV_UART_BUS_H_ -#include - /* Drain and flush targets. */ #define UART_DRAIN_RECEIVER 0x0001 #define UART_DRAIN_TRANSMITTER 0x0002 @@ -111,12 +109,12 @@ int sc_callout:1; /* This UART is opened for callout. */ int sc_fastintr:1; /* This UART uses fast interrupts. */ int sc_hasfifo:1; /* This UART has FIFOs. */ + int sc_hwiflow:1; /* This UART has HW input flow ctl. */ + int sc_hwoflow:1; /* This UART has HW output flow ctl. */ int sc_leaving:1; /* This UART is going away. */ int sc_opened:1; /* This UART is open for business. */ int sc_polled:1; /* This UART has no interrupts. */ - int sc_rtscts:1; /* This UART can do HW flow control. */ int sc_txbusy:1; /* This UART is transmitting. */ - int sc_xonxoff:1; /* This UART can do SW flow control. */ struct uart_devinfo *sc_sysdev; /* System device (or NULL). */