From owner-freebsd-wireless@FreeBSD.ORG  Fri May  4 20:40:08 2012
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0D4C3106564A
	for <freebsd-wireless@hub.freebsd.org>;
	Fri,  4 May 2012 20:40:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id EC1078FC0A
	for <freebsd-wireless@hub.freebsd.org>;
	Fri,  4 May 2012 20:40:07 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q44Ke7Lb004004
	for <freebsd-wireless@freefall.freebsd.org>;
	Fri, 4 May 2012 20:40:07 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q44Ke7Tc004003;
	Fri, 4 May 2012 20:40:07 GMT (envelope-from gnats)
Date: Fri, 4 May 2012 20:40:07 GMT
Message-Id: <201205042040.q44Ke7Tc004003@freefall.freebsd.org>
To: freebsd-wireless@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/167588: commit references a PR
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: "Discussions of 802.11 stack,
	tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 May 2012 20:40:08 -0000

The following reply was made to PR kern/167588; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/167588: commit references a PR
Date: Fri,  4 May 2012 20:31:37 +0000 (UTC)

 Author: adrian
 Date: Fri May  4 20:31:27 2012
 New Revision: 235034
 URL: http://svn.freebsd.org/changeset/base/235034
 
 Log:
   Fix a couple of sc_ac2q[] mappings that were using the TID, not the AC.
   
   PR:		kern/167588
 
 Modified:
   head/sys/dev/ath/if_ath_tx.c
 
 Modified: head/sys/dev/ath/if_ath_tx.c
 ==============================================================================
 --- head/sys/dev/ath/if_ath_tx.c	Fri May  4 19:49:24 2012	(r235033)
 +++ head/sys/dev/ath/if_ath_tx.c	Fri May  4 20:31:27 2012	(r235034)
 @@ -4307,9 +4307,9 @@ ath_addba_request(struct ieee80211_node 
  	 * it'll be "after" the left edge of the BAW and thus it'll
  	 * fall within it.
  	 */
 -	ATH_TXQ_LOCK(sc->sc_ac2q[atid->tid]);
 +	ATH_TXQ_LOCK(sc->sc_ac2q[atid->ac]);
  	ath_tx_tid_pause(sc, atid);
 -	ATH_TXQ_UNLOCK(sc->sc_ac2q[atid->tid]);
 +	ATH_TXQ_UNLOCK(sc->sc_ac2q[atid->ac]);
  
  	DPRINTF(sc, ATH_DEBUG_SW_TX_CTRL,
  	    "%s: called; dialogtoken=%d, baparamset=%d, batimeout=%d\n",
 @@ -4395,9 +4395,9 @@ ath_addba_stop(struct ieee80211_node *ni
  	DPRINTF(sc, ATH_DEBUG_SW_TX_CTRL, "%s: called\n", __func__);
  
  	/* Pause TID traffic early, so there aren't any races */
 -	ATH_TXQ_LOCK(sc->sc_ac2q[atid->tid]);
 +	ATH_TXQ_LOCK(sc->sc_ac2q[atid->ac]);
  	ath_tx_tid_pause(sc, atid);
 -	ATH_TXQ_UNLOCK(sc->sc_ac2q[atid->tid]);
 +	ATH_TXQ_UNLOCK(sc->sc_ac2q[atid->ac]);
  
  	/* There's no need to hold the TXQ lock here */
  	sc->sc_addba_stop(ni, tap);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"