Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 May 2012 20:40:07 GMT
From:      dfilter@FreeBSD.ORG (dfilter service)
To:        freebsd-wireless@FreeBSD.org
Subject:   Re: kern/167588: commit references a PR
Message-ID:  <201205042040.q44Ke7Tc004003@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/167588; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/167588: commit references a PR
Date: Fri,  4 May 2012 20:31:37 +0000 (UTC)

 Author: adrian
 Date: Fri May  4 20:31:27 2012
 New Revision: 235034
 URL: http://svn.freebsd.org/changeset/base/235034
 
 Log:
   Fix a couple of sc_ac2q[] mappings that were using the TID, not the AC.
   
   PR:		kern/167588
 
 Modified:
   head/sys/dev/ath/if_ath_tx.c
 
 Modified: head/sys/dev/ath/if_ath_tx.c
 ==============================================================================
 --- head/sys/dev/ath/if_ath_tx.c	Fri May  4 19:49:24 2012	(r235033)
 +++ head/sys/dev/ath/if_ath_tx.c	Fri May  4 20:31:27 2012	(r235034)
 @@ -4307,9 +4307,9 @@ ath_addba_request(struct ieee80211_node 
  	 * it'll be "after" the left edge of the BAW and thus it'll
  	 * fall within it.
  	 */
 -	ATH_TXQ_LOCK(sc->sc_ac2q[atid->tid]);
 +	ATH_TXQ_LOCK(sc->sc_ac2q[atid->ac]);
  	ath_tx_tid_pause(sc, atid);
 -	ATH_TXQ_UNLOCK(sc->sc_ac2q[atid->tid]);
 +	ATH_TXQ_UNLOCK(sc->sc_ac2q[atid->ac]);
  
  	DPRINTF(sc, ATH_DEBUG_SW_TX_CTRL,
  	    "%s: called; dialogtoken=%d, baparamset=%d, batimeout=%d\n",
 @@ -4395,9 +4395,9 @@ ath_addba_stop(struct ieee80211_node *ni
  	DPRINTF(sc, ATH_DEBUG_SW_TX_CTRL, "%s: called\n", __func__);
  
  	/* Pause TID traffic early, so there aren't any races */
 -	ATH_TXQ_LOCK(sc->sc_ac2q[atid->tid]);
 +	ATH_TXQ_LOCK(sc->sc_ac2q[atid->ac]);
  	ath_tx_tid_pause(sc, atid);
 -	ATH_TXQ_UNLOCK(sc->sc_ac2q[atid->tid]);
 +	ATH_TXQ_UNLOCK(sc->sc_ac2q[atid->ac]);
  
  	/* There's no need to hold the TXQ lock here */
  	sc->sc_addba_stop(ni, tap);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205042040.q44Ke7Tc004003>