From owner-svn-src-head@FreeBSD.ORG Sun Apr 19 23:07:30 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 11A13106567E; Sun, 19 Apr 2009 23:07:30 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id CB8818FC12; Sun, 19 Apr 2009 23:07:29 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id 889A146B38; Sun, 19 Apr 2009 19:07:29 -0400 (EDT) Date: Mon, 20 Apr 2009 00:07:29 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org In-Reply-To: <200904192302.n3JN2o6Z023217@svn.freebsd.org> Message-ID: References: <200904192302.n3JN2o6Z023217@svn.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Subject: Re: svn commit: r191291 - in head: lib/libthr/thread libexec/rtld-elf/amd64 libexec/rtld-elf/arm libexec/rtld-elf/i386 libexec/rtld-elf/ia64 libexec/rtld-elf/mips libexec/rtld-elf/powerpc libexec/rtld-... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2009 23:07:30 -0000 On Sun, 19 Apr 2009, Robert Watson wrote: > Now that the kernel defines CACHE_LINE_SIZE in machine/param.h, use > that definition in the custom locking code for the run-time linker > rather than local definitions. This actually changes the line size used by the rtld code for pre-pthreads locking for several architectures. I think this is an improvement, but if architecture maintainers could comment on that, that would be helpful. Robert N M Watson Computer Laboratory University of Cambridge > > Pointed out by: tinderbox > MFC after: 2 weeks > > Modified: > head/lib/libthr/thread/thr_rtld.c > head/libexec/rtld-elf/amd64/rtld_machdep.h > head/libexec/rtld-elf/arm/rtld_machdep.h > head/libexec/rtld-elf/i386/rtld_machdep.h > head/libexec/rtld-elf/ia64/rtld_machdep.h > head/libexec/rtld-elf/mips/rtld_machdep.h > head/libexec/rtld-elf/powerpc/rtld_machdep.h > head/libexec/rtld-elf/sparc64/rtld_machdep.h > > Modified: head/lib/libthr/thread/thr_rtld.c > ============================================================================== > --- head/lib/libthr/thread/thr_rtld.c Sun Apr 19 22:58:36 2009 (r191290) > +++ head/lib/libthr/thread/thr_rtld.c Sun Apr 19 23:02:50 2009 (r191291) > @@ -39,8 +39,6 @@ > #undef errno > extern int errno; > > -#define CACHE_LINE_SIZE 64 > - > static int _thr_rtld_clr_flag(int); > static void *_thr_rtld_lock_create(void); > static void _thr_rtld_lock_destroy(void *); > > Modified: head/libexec/rtld-elf/amd64/rtld_machdep.h > ============================================================================== > --- head/libexec/rtld-elf/amd64/rtld_machdep.h Sun Apr 19 22:58:36 2009 (r191290) > +++ head/libexec/rtld-elf/amd64/rtld_machdep.h Sun Apr 19 23:02:50 2009 (r191291) > @@ -32,8 +32,6 @@ > #include > #include > > -#define CACHE_LINE_SIZE 64 > - > struct Struct_Obj_Entry; > > /* Return the address of the .dynamic section in the dynamic linker. */ > > Modified: head/libexec/rtld-elf/arm/rtld_machdep.h > ============================================================================== > --- head/libexec/rtld-elf/arm/rtld_machdep.h Sun Apr 19 22:58:36 2009 (r191290) > +++ head/libexec/rtld-elf/arm/rtld_machdep.h Sun Apr 19 23:02:50 2009 (r191291) > @@ -32,8 +32,6 @@ > #include > #include > > -#define CACHE_LINE_SIZE 32 > - > struct Struct_Obj_Entry; > > /* Return the address of the .dynamic section in the dynamic linker. */ > > Modified: head/libexec/rtld-elf/i386/rtld_machdep.h > ============================================================================== > --- head/libexec/rtld-elf/i386/rtld_machdep.h Sun Apr 19 22:58:36 2009 (r191290) > +++ head/libexec/rtld-elf/i386/rtld_machdep.h Sun Apr 19 23:02:50 2009 (r191291) > @@ -32,8 +32,6 @@ > #include > #include > > -#define CACHE_LINE_SIZE 32 > - > struct Struct_Obj_Entry; > > /* Return the address of the .dynamic section in the dynamic linker. */ > > Modified: head/libexec/rtld-elf/ia64/rtld_machdep.h > ============================================================================== > --- head/libexec/rtld-elf/ia64/rtld_machdep.h Sun Apr 19 22:58:36 2009 (r191290) > +++ head/libexec/rtld-elf/ia64/rtld_machdep.h Sun Apr 19 23:02:50 2009 (r191291) > @@ -32,8 +32,6 @@ > #include > #include > > -#define CACHE_LINE_SIZE 128 > - > /* > * Macros for cracking ia64 function pointers. > */ > > Modified: head/libexec/rtld-elf/mips/rtld_machdep.h > ============================================================================== > --- head/libexec/rtld-elf/mips/rtld_machdep.h Sun Apr 19 22:58:36 2009 (r191290) > +++ head/libexec/rtld-elf/mips/rtld_machdep.h Sun Apr 19 23:02:50 2009 (r191291) > @@ -32,8 +32,6 @@ > #include > #include > > -#define CACHE_LINE_SIZE 32 > - > struct Struct_Obj_Entry; > > /* Return the address of the .dynamic section in the dynamic linker. */ > > Modified: head/libexec/rtld-elf/powerpc/rtld_machdep.h > ============================================================================== > --- head/libexec/rtld-elf/powerpc/rtld_machdep.h Sun Apr 19 22:58:36 2009 (r191290) > +++ head/libexec/rtld-elf/powerpc/rtld_machdep.h Sun Apr 19 23:02:50 2009 (r191291) > @@ -32,8 +32,6 @@ > #include > #include > > -#define CACHE_LINE_SIZE 32 > - > struct Struct_Obj_Entry; > > /* Return the address of the .dynamic section in the dynamic linker. */ > > Modified: head/libexec/rtld-elf/sparc64/rtld_machdep.h > ============================================================================== > --- head/libexec/rtld-elf/sparc64/rtld_machdep.h Sun Apr 19 22:58:36 2009 (r191290) > +++ head/libexec/rtld-elf/sparc64/rtld_machdep.h Sun Apr 19 23:02:50 2009 (r191291) > @@ -32,8 +32,6 @@ > #include > #include > > -#define CACHE_LINE_SIZE 128 > - > struct Struct_Obj_Entry; > > /* Return the address of the .dynamic section in the dynamic linker. */ >