Date: Wed, 20 Feb 2002 15:17:06 -0800 (PST) From: Kelly Yancey <kbyanc@posi.net> To: Joerg Wunsch <joerg_wunsch@uriah.heep.sax.de> Cc: freebsd-scsi@FreeBSD.ORG Subject: Re: RBC support patch Message-ID: <20020220151340.V86607-100000@gateway.posi.net> In-Reply-To: <20020220134946.X86372-100000@gateway.posi.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 20 Feb 2002, Kelly Yancey wrote:
> You are right, SCSI 3 lists both 6 and 10-byte READ/WRITE commands are
> mandatory. However, SCSI 2 lists both as optional. So we could just key off
> the INQUIRY results and if the device reports itself as SCSI3 or newer force
> 10 byte commands, otherwise keep using 6 byte commands. Sounds reasonable to
> me.
> What will be interesting is seeing if this would fix all the SCSI->USB
> quirks along the way (i.e. do they report themselves as SCSI3 conforming?).
>
> I'll make up a quick patch and post it for review shortly.
>
> Kelly
[replying to self]
Here is a quick patch that should do the trick. I haven't tested it yet,
though (it's pretty straightforward) as I have to wait for my current box to
rebuild.
Kelly
kbyanc@{posi.net,FreeBSD.org}
P.S. In theory we could add a warning if a quirk containing only
DA_Q_NO_6_BYTE is found and the device reports itself as SCSI3 alerting
us that we can safely remove the quirk.
Index: scsi_da.c
===================================================================
RCS file: /home/ncvs/src/sys/cam/scsi/scsi_da.c,v
retrieving revision 1.97
diff -u -r1.97 scsi_da.c
--- scsi_da.c 18 Feb 2002 13:35:30 -0000 1.97
+++ scsi_da.c 20 Feb 2002 23:13:32 -0000
@@ -1131,7 +1131,8 @@
else
softc->quirks = DA_Q_NONE;
- if (softc->quirks & DA_Q_NO_6_BYTE)
+ if ((softc->quirks & DA_Q_NO_6_BYTE) ||
+ (SID_ANSI_REV(&cgd->inq_data) >= SCSI_REV_3))
softc->minimum_cmd_size = 10;
else
softc->minimum_cmd_size = 6;
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-scsi" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020220151340.V86607-100000>