From owner-freebsd-stable@freebsd.org Sun Jul 8 22:03:16 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8819F103A12E for ; Sun, 8 Jul 2018 22:03:16 +0000 (UTC) (envelope-from daniel@ftml.net) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 469478E75B for ; Sun, 8 Jul 2018 22:03:16 +0000 (UTC) (envelope-from daniel@ftml.net) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 41FA12B9 for ; Sun, 8 Jul 2018 18:03:08 -0400 (EDT) Received: from web6 ([10.202.2.216]) by compute3.internal (MEProxy); Sun, 08 Jul 2018 18:03:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ftml.net; h= content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=fnbcU2696lpiHKKEAc05ceQZraZPfmTdExjh5t5leX8=; b=s2+Qktni 8hIfcy40dQ8QjTdQKcdtM6xLwGJbSOmO0+HvtQIhaHYEbK58xXNwQmj8FO/YEB69 HuuuZN2Lp4OkXYOc/7d/G/ierzkaCn6em26ScQufezhDS/r3EUl/9K31r2sxCefg B3plB5YbGw4pV+ZE1+LpLc7rd4wPZ246OMzCcaKP76pNl5wpu6cwV3Rtojc9nxK3 nTvMTizevIGipkiKFN5g0lGl2L+jqJol+MQxN0+8GtjTHSw04YAUwrd984CSExYr WDREkd6kd6jae16kxIvZYV8YrjRmIl6x6bfY9GHrSN6fBjxE/OXie3j4c09kKVdN gDcfDEkmjNhuYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=fnbcU2696lpiHKKEAc05ceQZraZPf mTdExjh5t5leX8=; b=WgiY+Z9hdsf0fewwTDVQnZ/a9kXq7vk4rw4NhbJGSAvxT nTfmF4OjP0BNGsvIs+BNELx///O9W3umy2fna3O+Wi2g2cpCqn+6i95/wCIlMQxI 7J38mue9AJ1wS2jAdvHNZWRey8mDT+4XthG4QLM6NNPiZYBKa8zXB3m5qeYph3Fd J6q+XViPr/P8UidPXfSjnGCd1m9pYBVXLODjEi3tNkCrnpfWGCDUzEeXwXc75YK1 0x217aZ070kZ2cF7pjk5aC3wvzOsKIXxB/izOvZ9VK4skrjZV2uK3G5LgXZ0/oa9 YTgfTtzyZNbUTIIQeI1kz+wqPPPAEvoIGxZkgnfKQ== X-ME-Proxy: X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 5D179418D; Sun, 8 Jul 2018 18:03:07 -0400 (EDT) Message-Id: <1531087387.2543270.1433935616.5272EA26@webmail.messagingengine.com> From: Daniel Engel To: freebsd-stable@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-0d8ea36c Subject: RE: NFS 4.1 RECLAIM_COMPLETE FS failed error Date: Sun, 08 Jul 2018 15:03:07 -0700 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2018 22:03:16 -0000 Hi, I am setting up an environment with FreeBSD 11.1 sharing a ZFS datastore to vmware ESXI 6.7. There were a number of errors with NFS 4.1 sharing that I didn't understand until I found the following thread. I traced the commits that Rick has made since that thread and merged them 'head' into 'stable': 'svnlite checkout http://svn.freebsd.org/base/release/11.1.0/' 'svnlite merge -c 332790 http://svn.freebsd.org/base/head' 'svnlite merge -c 333508 http://svn.freebsd.org/base/head' 'svnlite merge -c 333579 http://svn.freebsd.org/base/head' 'svnlite merge -c 333580 http://svn.freebsd.org/base/head' 'svnlite merge -c 333592 http://svn.freebsd.org/base/head' 'svnlite merge -c 333645 http://svn.freebsd.org/base/head' 'svnlite merge -c 333766 http://svn.freebsd.org/base/head' 'svnlite merge -c 334396 http://svn.freebsd.org/base/head' 'svnlite merge -c 334492 http://svn.freebsd.org/base/head' 'svnlite merge -c 327674 http://svn.freebsd.org/base/head' That completely fixed the connection instability, but the NFS share was still mounting read-only with a RECLAIM_COMPLETE error. So, I manually applied the first patch from the previous thread and everything started working: --- fs/nfsserver/nfs_nfsdserv.c.savrecl 2018-02-10 20:34:31.166445000 -0500 +++ fs/nfsserver/nfs_nfsdserv.c 2018-02-10 20:36:07.947490000 -0500 @@ -4226,10 +4226,9 @@ nfsrvd_reclaimcomplete(struct nfsrv_desc goto nfsmout; } NFSM_DISSECT(tl, uint32_t *, NFSX_UNSIGNED); + nd->nd_repstat = nfsrv_checkreclaimcomplete(nd); if (*tl == newnfs_true) - nd->nd_repstat = NFSERR_NOTSUPP; - else - nd->nd_repstat = nfsrv_checkreclaimcomplete(nd); + nd->nd_repstat = 0; The question is: Did I miss something? Is there an alternate change already in SVN that does the same thing better, or is there some corner case preventing this patch from being finalized that I just haven't run into yet? Thanks, Daniel Engel