From owner-svn-src-head@freebsd.org Mon Mar 18 21:40:04 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A59BE154EB54; Mon, 18 Mar 2019 21:40:04 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F18AF77F6E; Mon, 18 Mar 2019 21:40:03 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x2ILe2FD047247; Mon, 18 Mar 2019 14:40:02 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x2ILe2ve047246; Mon, 18 Mar 2019 14:40:02 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201903182140.x2ILe2ve047246@gndrsh.dnsmgr.net> Subject: Re: svn commit: r345238 - head In-Reply-To: <87798c27-8546-2c3b-0f23-83beca25ee7e@FreeBSD.org> To: John Baldwin Date: Mon, 18 Mar 2019 14:40:02 -0700 (PDT) CC: Wolfram Schneider , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: F18AF77F6E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.956,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Mar 2019 21:40:04 -0000 [ Charset UTF-8 unsupported, converting... ] > On 3/16/19 1:02 PM, Wolfram Schneider wrote: > > Author: wosch > > Date: Sat Mar 16 20:02:57 2019 > > New Revision: 345238 > > URL: https://svnweb.freebsd.org/changeset/base/345238 > > > > Log: > > `make buildkernel' should display the build time in seconds > > > > PR: 224433 > > Approved by: cem > > Differential Revision: https://reviews.freebsd.org/D13910 > > > > Modified: > > head/Makefile.inc1 > > > > Modified: head/Makefile.inc1 > > ============================================================================== > > --- head/Makefile.inc1 Sat Mar 16 17:55:22 2019 (r345237) > > +++ head/Makefile.inc1 Sat Mar 16 20:02:57 2019 (r345238) > > @@ -1584,6 +1584,11 @@ _cleankernobj_fast_depend_hack: .PHONY > > > > ${WMAKE_TGTS:N_worldtmp:Nbuild${libcompat}} ${.ALLTARGETS:M_*:N_worldtmp}: .MAKE .PHONY > > > > +# record kernel(s) build time in seconds > > +.if make(buildkernel) > > +_BUILDKERNEL_START!= date '+%s' > > +.endif > > + > > # > > # buildkernel > > # > > @@ -1640,7 +1645,12 @@ buildkernel: .MAKE .PHONY > > @echo "--------------------------------------------------------------" > > @echo ">>> Kernel build for ${_kernel} completed on `LC_ALL=C date`" > > @echo "--------------------------------------------------------------" > > + > > .endfor > > + @seconds=$$(($$(date '+%s') - ${_BUILDKERNEL_START})); \ > > + echo -n ">>> Kernel(s) build for${BUILDKERNELS} in $$seconds seconds, "; \ > > + echo "ncpu: $$(sysctl -n hw.ncpu)${.MAKE.JOBS:S/^/, make -j/}" > > + @echo "--------------------------------------------------------------" > > Both this and the previous message for buildworld should use 'built' instead > of 'build' so that the message is something like "World built in 47 seconds" > rather than "World build in 47 seconds". > > This sentence is also somewhat odd: > > "Kernel(s) build for FOO BAR BAZ in 47 seconds" > > Even with 'built' fixed, I feel like it should be more like: > > "FOO BAR BAZ kernel(s) built in 47 seconds" by moving ${BUILDKERNELS} to the > start of the message? "Kernel(s) ${BUILDKERNELS} built in 47 seconds" reads better for me. > John Baldwin -- Rod Grimes rgrimes@freebsd.org