Date: Sun, 1 Dec 2024 10:58:32 +0100 (CET) From: Ronald Klop <ronald-lists@klop.ws> To: Mike Jakubik <mike.jakubik@gmail.com> Cc: freebsd-net@freebsd.org, ale@FreeBSD.org Subject: Re: FreeBSD Port: net/realtek-re-kmod Message-ID: <1944158676.16135.1733047112928@localhost> In-Reply-To: <b945f01a-6128-4d28-84b3-883ed388a994@gmail.com> References: <b945f01a-6128-4d28-84b3-883ed388a994@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_16134_1543477813.1733047112836 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: quoted-printable I think a quick fix for your problem was committed a few days ago (Nov 28). https://cgit.freebsd.org/ports/commit/?id=3D4ca9ea9d4060a4a494456a0e56306bd= 508fe20e8 Regards, Ronald. =20 Van: Mike Jakubik <mike.jakubik@gmail.com> Datum: zondag, 1 december 2024 01:59 Aan: ale@FreeBSD.org, freebsd-net@freebsd.org Onderwerp: FreeBSD Port: net/realtek-re-kmod >=20 > Any update on this from upstream maybe? Seems like an easy fix, I got new= system that needs this driver too (Realtek 5Gb). >=20 > Ty. >=20 >=20 > Hello, >=20 >=20 > Seems like it wont compile on recent current, noticed about 2 days ago a= nd /usr/src/sys/sys/mbuf.h hasnt been touched it seems. >=20 > 15.0-CURRENT FreeBSD 15.0-CURRENT #0 main-56043cbfdd: Thu Nov 21 20:30:44= EST 2024 >=20 >=20 > [root@fbsd15 /usr/ports/net/realtek-re-kmod]# make MAKE_JOBS_UNSAFE=3Dyes > =3D=3D=3D> Building for realtek-re-kmod-1100.00_1 > Warning: Object directory not changed from original /usr/ports/net/realte= k-re-kmod/work/rtl_bsd_drv-ea4ed1e > cc -O2 -pipe -fno-strict-aliasing -DENABLE_INTERRUPT_MITIGATIN -Werror -= D_KERNEL -DKLD_MODULE -nostdinc -include /usr/ports/net/realtek-re-kmod/w= ork/rtl_bsd_drv-ea4ed1e/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/cont= rib/ck/include -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-poi= nter -fdebug-prefix-map=3D./machine=3D/usr/src/sys/amd64/include -fdebug-pr= efix-map=3D./x86=3D/usr/src/sys/x86/include -fdebug-prefix-map=3D./i386=3D/= usr/src/sys/i386/include -MD -MF.depend.if_re.o -MTif_re.o -mcmodel=3Dke= rnel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind= -tables -ffreestanding -fwrapv -fstack-protector -Wall -Wstrict-prototypes= -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign= -D__printf__=3D__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-sh= ow-option -Wno-unknown-pragmas -Wswitch -Wno-error=3Dtautological-compare -= Wno-error=3Dempty-body -Wno-error=3Dparentheses-equality -Wno-error=3Dunuse= d-function -Wno-error=3Dpointer-sign -Wno-error=3Dshift-negative-value -Wno= -address-of-packed-member -Wno-format-zero-length -mno-aes -mno-avx -std= =3Dgnu99 -c if_re.c -o if_re.o > if_re.c:1270:37: error: incomplete definition of type 'struct ifnet' > 1270 | sc->re_rx_desc_buf_sz =3D (ifp->if_mtu > ETHERMTU) ? ifp->= if_mtu: ETHERMTU; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:1270:63: error: incomplete definition of type 'struct ifnet' > 1270 | sc->re_rx_desc_buf_sz =3D (ifp->if_mtu > ETHERMTU) ? ifp->= if_mtu: ETHERMTU; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:4562:60: error: incomplete definition of type 'struct ifnet' > 4562 | printf("if_drv_flags\t0x%08x\n", sc->re_ifp->if_dr= v_flags); > | ~~~~~~~~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:4622:43: error: call to undeclared function 'IF_LLADDR'; ISO C99 = and later do not support implicit function declarations [-Werror,-Wimplicit= -function-declaration] > 4622 | printf("dev_addr\t%6D\n", IF_LLADDR(sc->re_ifp), "= :"); > | ^ > if_re.c:4622:43: error: format specifies type 'void *' but the argument h= as type 'int' [-Werror,-Wformat] > 4622 | printf("dev_addr\t%6D\n", IF_LLADDR(sc->re_ifp), "= :"); > | ~~~ ^~~~~~~~~~~~~~~~~~~~~ > if_re.c:4662:32: error: incomplete definition of type 'struct ifnet' > 4662 | if ((sc->re_ifp->if_drv_flags & IFF_DRV_RUNNING) = =3D=3D 0) { > | ~~~~~~~~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:5522:12: error: incomplete definition of type 'struct ifnet' > 5522 | ifp->if_softc =3D sc; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:5529:12: error: incomplete definition of type 'struct ifnet' > 5529 | ifp->if_mtu =3D ETHERMTU; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:5530:12: error: incomplete definition of type 'struct ifnet' > 5530 | ifp->if_flags =3D IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTIC= AST; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:5531:12: error: incomplete definition of type 'struct ifnet' > 5531 | ifp->if_ioctl =3D re_ioctl; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:5532:12: error: incomplete definition of type 'struct ifnet' > 5532 | ifp->if_output =3D ether_output; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:5533:12: error: incomplete definition of type 'struct ifnet' > 5533 | ifp->if_start =3D re_start; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:5538:20: error: incomplete definition of type 'struct ifnet' > 5538 | ifp->if_hwassist |=3D CSUM_TCP | CSUM_UDP; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:5540:20: error: incomplete definition of type 'struct ifnet' > 5540 | ifp->if_hwassist |=3D RE_CSUM_FEATURES; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:5541:12: error: incomplete definition of type 'struct ifnet' > 5541 | ifp->if_capabilities =3D IFCAP_HWCSUM | IFCAP_HWCSUM_IPV6; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:5544:20: error: incomplete definition of type 'struct ifnet' > 5544 | ifp->if_hwassist |=3D CSUM_TSO; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:5545:20: error: incomplete definition of type 'struct ifnet' > 5545 | ifp->if_capabilities |=3D IFCAP_TSO; > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:5549:20: error: incomplete definition of type 'struct ifnet' > 5549 | ifp->if_hwassist &=3D ~(CSUM_IP6_TSO | > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > if_re.c:5552:20: error: incomplete definition of type 'struct ifnet' > 5552 | ifp->if_capabilities &=3D ~(IFCAP_TSO6 | IFCAP_HWC= SUM_IPV6); > | ~~~^ > /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet= ' > 139 | struct ifnet *ifp; /* network interface tag be= longs to */ > | ^ > fatal error: too many errors emitted, stopping now [-ferror-limit=3D] > 20 errors generated. > *** Error code 1 >=20 > Stop. > make: stopped making "all" in /usr/ports/net/realtek-re-kmod/work/rtl_bsd= _drv-ea4ed1e > *** Error code 1 >=20 > Stop. > make: stopped making "all" in /usr/ports/net/realtek-re-kmod > [root@fbsd15 /usr/ports/net/realtek-re-kmod]# >=20 >=20 > =20 >=20 >=20 >=20 =20 ------=_Part_16134_1543477813.1733047112836 Content-Type: text/html; charset=us-ascii Content-Transfer-Encoding: quoted-printable <html><head></head><body>I think a quick fix for your problem was committed= a few days ago (Nov 28).<br> <br> <a href=3D"https://cgit.freebsd.org/ports/commit/?id=3D4ca9ea9d4060a4a49445= 6a0e56306bd508fe20e8">https://cgit.freebsd.org/ports/commit/?id=3D4ca9ea9d4= 060a4a494456a0e56306bd508fe20e8</a><br> <br> Regards,<br> Ronald.<br> <br> <p><strong>Van:</strong> Mike Jakubik <mike.jakubik@gmail.com><br> <strong>Datum:</strong> zondag, 1 december 2024 01:59<br> <strong>Aan:</strong> ale@FreeBSD.org, freebsd-net@freebsd.org<br> <strong>Onderwerp:</strong> FreeBSD Port: net/realtek-re-kmod</p> <blockquote style=3D"padding-right: 0px; padding-left: 5px; margin-left: 5p= x; border-left: #000000 2px solid; margin-right: 0px"> <div class=3D"MessageRFC822Viewer" id=3D"P"> <div class=3D"TextPlainViewer" id=3D"P.P">Any update on this from upstream = maybe? Seems like an easy fix, I got new system that needs this driver too = (Realtek 5Gb).<br> <br> Ty.<br> <br> <br> Hello,<br> <br> <br> Seems like it wont compile on recent current, noticed about 2 days ag= o and /usr/src/sys/sys/mbuf.h hasnt been touched it seems.<br> <br> 15.0-CURRENT FreeBSD 15.0-CURRENT #0 main-56043cbfdd: Thu Nov 21 20:30:44 E= ST 2024<br> <br> <br> [root@fbsd15 /usr/ports/net/realtek-re-kmod]# make MAKE_JOBS_UNSAFE=3Dyes<b= r> =3D=3D=3D> Building for realtek-re-kmod-1100.00_1<br> Warning: Object directory not changed from original /usr/ports/net/realtek-= re-kmod/work/rtl_bsd_drv-ea4ed1e<br> cc -O2 -pipe -fno-strict-aliasing -DENABLE_INTERRUPT_MITIGATIN -Werro= r -D_KERNEL -DKLD_MODULE -nostdinc -include /usr/ports/net/real= tek-re-kmod/work/rtl_bsd_drv-ea4ed1e/opt_global.h -I. -I/usr/src/sys -I/usr= /src/sys/contrib/ck/include -fno-common -fno-omit-frame-pointer -mno-omit-l= eaf-frame-pointer -fdebug-prefix-map=3D./machine=3D/usr/src/sys/amd64/inclu= de -fdebug-prefix-map=3D./x86=3D/usr/src/sys/x86/include -fdebug-prefix-map= =3D./i386=3D/usr/src/sys/i386/include -MD -MF.depend.if_r= e.o -MTif_re.o -mcmodel=3Dkernel -mno-red-zone -mno-mmx -mno-sse -msoft-flo= at -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-pro= tector -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith= -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=3D__freebsd_kprintf__ -= Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wswit= ch -Wno-error=3Dtautological-compare -Wno-error=3Dempty-body -Wno-error=3Dp= arentheses-equality -Wno-error=3Dunused-function -Wno-error=3Dpointer-sign = -Wno-error=3Dshift-negative-value -Wno-address-of-packed-member -Wno-format= -zero-length -mno-aes -mno-avx -std=3Dgnu99 -c if_re.c -o= if_re.o<br> if_re.c:1270:37: error: incomplete definition of type 'struct ifnet'<br> 1270 | sc->re_rx_desc_bu= f_sz =3D (ifp->if_mtu > ETHERMTU) ? ifp->if_mtu: ETHERMTU;<br> | &n= bsp;  = ; ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:1270:63: error: incomplete definition of type 'struct ifnet'<br> 1270 | sc->re_rx_desc_bu= f_sz =3D (ifp->if_mtu > ETHERMTU) ? ifp->if_mtu: ETHERMTU;<br> | &n= bsp;  = ; &n= bsp;  = ; ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:4562:60: error: incomplete definition of type 'struct ifnet'<br> 4562 | &nb= sp; printf("if_drv_flags\t0x%08x\n", sc->re_ifp-= >if_drv_flags);<br> | &n= bsp;  = ; &n= bsp; ~~~~= ~~~~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:4622:43: error: call to undeclared function 'IF_LLADDR'; ISO C99 an= d later do not support implicit function declarations [-Werror,-Wimplicit-f= unction-declaration]<br> 4622 | &nb= sp; printf("dev_addr\t%6D\n", IF_LLADDR(sc->re_i= fp), ":");<br> | &n= bsp;  = ; &n= bsp; ^<br> if_re.c:4622:43: error: format specifies type 'void *' but the argument has= type 'int' [-Werror,-Wformat]<br> 4622 | &nb= sp; printf("dev_addr\t%6D\n", IF_LLADDR(sc->re_i= fp), ":");<br> | &n= bsp;  = ; ~~~ &nbs= p; ^~~~~~~~~~~~~~~~~~~~~<br> if_re.c:4662:32: error: incomplete definition of type 'struct ifnet'<br> 4662 | &nb= sp; if ((sc->re_ifp->if_drv_flags & IFF_D= RV_RUNNING) =3D=3D 0) {<br> | &n= bsp; ~~~~~~~~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:5522:12: error: incomplete definition of type 'struct ifnet'<br> 5522 | ifp->if_softc =3D= sc;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:5529:12: error: incomplete definition of type 'struct ifnet'<br> 5529 | ifp->if_mtu =3D E= THERMTU;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:5530:12: error: incomplete definition of type 'struct ifnet'<br> 5530 | ifp->if_flags =3D= IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:5531:12: error: incomplete definition of type 'struct ifnet'<br> 5531 | ifp->if_ioctl =3D= re_ioctl;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:5532:12: error: incomplete definition of type 'struct ifnet'<br> 5532 | ifp->if_output = =3D ether_output;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:5533:12: error: incomplete definition of type 'struct ifnet'<br> 5533 | ifp->if_start =3D= re_start;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:5538:20: error: incomplete definition of type 'struct ifnet'<br> 5538 | &nb= sp; ifp->if_hwassist |=3D CSUM_TCP | CSUM_UDP;<b= r> | &n= bsp; ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:5540:20: error: incomplete definition of type 'struct ifnet'<br> 5540 | &nb= sp; ifp->if_hwassist |=3D RE_CSUM_FEATURES;<br> | &n= bsp; ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:5541:12: error: incomplete definition of type 'struct ifnet'<br> 5541 | ifp->if_capabilit= ies =3D IFCAP_HWCSUM | IFCAP_HWCSUM_IPV6;<br> | ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:5544:20: error: incomplete definition of type 'struct ifnet'<br> 5544 | &nb= sp; ifp->if_hwassist |=3D CSUM_TSO;<br> | &n= bsp; ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:5545:20: error: incomplete definition of type 'struct ifnet'<br> 5545 | &nb= sp; ifp->if_capabilities |=3D IFCAP_TSO;<br> | &n= bsp; ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:5549:20: error: incomplete definition of type 'struct ifnet'<br> 5549 | &nb= sp; ifp->if_hwassist &=3D ~(CSUM_IP6_TSO |<b= r> | &n= bsp; ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> if_re.c:5552:20: error: incomplete definition of type 'struct ifnet'<br> 5552 | &nb= sp; ifp->if_capabilities &=3D ~(IFCAP_TSO6 |= IFCAP_HWCSUM_IPV6);<br> | &n= bsp; ~~~^<br> /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of 'struct ifnet'<= br> 139 | struct ifnet *ifp;&nb= sp; = /* network interface tag belongs to */<br> | &n= bsp; ^<br> fatal error: too many errors emitted, stopping now [-ferror-limit=3D]<br> 20 errors generated.<br> *** Error code 1<br> <br> Stop.<br> make: stopped making "all" in /usr/ports/net/realtek-re-kmod/work/rtl_bsd_d= rv-ea4ed1e<br> *** Error code 1<br> <br> Stop.<br> make: stopped making "all" in /usr/ports/net/realtek-re-kmod<br> [root@fbsd15 /usr/ports/net/realtek-re-kmod]#<br> <br> <br> </div> <hr></div> </blockquote> <br> </body></html> ------=_Part_16134_1543477813.1733047112836--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1944158676.16135.1733047112928>