Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 3 Mar 2025 01:39:52 GMT
From:      Kevin Lo <kevlo@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 42ba6765c932 - stable/13 - ixgbe: Fix a logic error in ixgbe_read_mailbox_vf()
Message-ID:  <202503030139.5231dqkb066736@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by kevlo:

URL: https://cgit.FreeBSD.org/src/commit/?id=42ba6765c9328dd283e76ba26c048868033c89b2

commit 42ba6765c9328dd283e76ba26c048868033c89b2
Author:     Kevin Lo <kevlo@FreeBSD.org>
AuthorDate: 2025-02-28 08:12:00 +0000
Commit:     Kevin Lo <kevlo@FreeBSD.org>
CommitDate: 2025-03-03 01:39:28 +0000

    ixgbe: Fix a logic error in ixgbe_read_mailbox_vf()
    
    Reviewed by:    kbowling
    Differential Revision:  https://reviews.freebsd.org/D49156
    
    (cherry picked from commit 5c7087c349fc1d826807aa1a11912c9e774e3321)
---
 sys/dev/ixgbe/ixgbe_mbx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/ixgbe/ixgbe_mbx.c b/sys/dev/ixgbe/ixgbe_mbx.c
index 5f1f64e02b82..0b866e7a39af 100644
--- a/sys/dev/ixgbe/ixgbe_mbx.c
+++ b/sys/dev/ixgbe/ixgbe_mbx.c
@@ -297,7 +297,7 @@ static u32 ixgbe_read_mailbox_vf(struct ixgbe_hw *hw)
 	u32 vf_mailbox = IXGBE_READ_REG(hw, IXGBE_VFMAILBOX);
 
 	vf_mailbox |= hw->mbx.vf_mailbox;
-	hw->mbx.vf_mailbox |= vf_mailbox % IXGBE_VFMAILBOX_R2C_BITS;
+	hw->mbx.vf_mailbox |= vf_mailbox & IXGBE_VFMAILBOX_R2C_BITS;
 
 	return vf_mailbox;
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202503030139.5231dqkb066736>