From owner-freebsd-current@FreeBSD.ORG  Tue Oct 12 15:24:41 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 83A87106564A
	for <freebsd-current@freebsd.org>; Tue, 12 Oct 2010 15:24:41 +0000 (UTC)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
	[128.208.78.105])
	by mx1.freebsd.org (Postfix) with ESMTP id 605C58FC08
	for <freebsd-current@freebsd.org>; Tue, 12 Oct 2010 15:24:41 +0000 (UTC)
Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu
	[127.0.0.1])
	by troutmask.apl.washington.edu (8.14.4/8.14.4) with ESMTP id
	o9CFOfk6001690; Tue, 12 Oct 2010 08:24:41 -0700 (PDT)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
	by troutmask.apl.washington.edu (8.14.4/8.14.4/Submit) id
	o9CFOegP001689; Tue, 12 Oct 2010 08:24:40 -0700 (PDT)
	(envelope-from sgk)
Date: Tue, 12 Oct 2010 08:24:40 -0700
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Pyun YongHyeon <pyunyh@gmail.com>
Message-ID: <20101012152440.GA1615@troutmask.apl.washington.edu>
References: <20101011225331.GA2829@troutmask.apl.washington.edu>
	<20101011231604.GI4607@michelle.cdnetworks.com>
	<20101012000216.GA1554@troutmask.apl.washington.edu>
	<20101012000927.GK4607@michelle.cdnetworks.com>
	<20101012001510.GA6789@troutmask.apl.washington.edu>
	<20101012002621.GA1554@troutmask.apl.washington.edu>
	<20101012003329.GL4607@michelle.cdnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101012003329.GL4607@michelle.cdnetworks.com>
User-Agent: Mutt/1.4.2.3i
Cc: freebsd-current@freebsd.org
Subject: Re: recent bge(4) changes causing problems
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Oct 2010 15:24:41 -0000

On Mon, Oct 11, 2010 at 05:33:29PM -0700, Pyun YongHyeon wrote:
> 
> Thanks for the info. I still suspect r213495 might break BCM5704.
> Due to lack of BCM5704 I still couldn't test it except guessing.
> How about attached one?

> Index: sys/dev/bge/if_bge.c
> ===================================================================
> --- sys/dev/bge/if_bge.c	(revision 213711)
> +++ sys/dev/bge/if_bge.c	(working copy)
> @@ -1736,7 +1736,8 @@
>  		RCB_WRITE_4(sc, vrcb, bge_hostaddr.bge_addr_hi, 0);
>  		RCB_WRITE_4(sc, vrcb, bge_hostaddr.bge_addr_lo, 0);
>  		RCB_WRITE_4(sc, vrcb, bge_maxlen_flags,
> -		    BGE_RCB_FLAG_RING_DISABLED);
> +		    BGE_RCB_MAXLEN_FLAGS(sc->bge_return_ring_cnt,
> +		    BGE_RCB_FLAG_RING_DISABLED));
>  		RCB_WRITE_4(sc, vrcb, bge_nicaddr, 0);
>  		bge_writembx(sc, BGE_MBX_RX_CONS0_LO +
>  		    (i * (sizeof(uint64_t))), 0);

Unfortunately, this patch does not fix the issue.

If I revert r213495 via 'svn merge -r213495:213494 .'
in the sys/dev/bge directory, I can build a working
kernel.  So, I can confirm that r213495 is the source
of the problem with a BCM5704 based NIC.


-- 
Steve