From owner-svn-src-all@freebsd.org Sun Jun 3 20:25:29 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F7FBFF7800 for ; Sun, 3 Jun 2018 20:25:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C5CED7AA4E for ; Sun, 3 Jun 2018 20:25:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x230.google.com with SMTP id g22-v6so7490574iob.7 for ; Sun, 03 Jun 2018 13:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yN9LC7isxNMkH1FAneZs16d6/7yOmUaUEDZYwieoiMU=; b=dyRnxxk0qoutuPnLvzIYk1UMlz9TIlwqTpPq6H/eh00AwzaIEIrGT8P5ujPEA3AZ5a epck93ydLurM1usaV1Do631mqhAbSvwguwIbZ2kcFKTLi6/9Txrm7yGOtebsIh3kPd0z xJ21Ggye6XCz67eifcOjD4VjE1rHXrBznT9TBr1inxtNkqJT186vvHIzjF2xH+zQVnsy MB05w9PlxrNeh2deA1Skx0j9Dlr4jiXOp7XwXGvokdqd7ZJPqzKQQrzn9iwEyCBwIsjM Duh/Gd+WvYnsfUVYoZ03MkqQ0K1B9zrnIAQrEmnQS4e7eFzTiX3Om+NxV3dFy/KRtOU+ ci1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yN9LC7isxNMkH1FAneZs16d6/7yOmUaUEDZYwieoiMU=; b=QSDd8aJK7oyws7WFeM7NnEm2Bn4ZzSCb0UkMuGhJ+r2Pa04M8CI6cGshxdQ7EMuTOM GTe+iQTSi+xCvWDgFWKQZBSNq0ttkHUr6gqtkg4i8x+VjZ+MBz4zDYRsf4rfqBUoOjV4 fkpNQPJFmMGwwsFfuIVb/pIBs5jLIMVz0+V04HzKJcff5/KIkuwI3FOuyhj5xkV4uY+U JiL+mewwCzkKDnN+yRzZFB1aUPlQPYbZrNfUS1v/k81YxBF/PQG1JozQsGLXiTPaySkz yeC3A4cm0MSUPT2MZF+3NVkfwjivMfWCN9h35rj4SmVi8/m9X2A4zLi5kEkgYX1wFvnA TPGg== X-Gm-Message-State: ALKqPwcIvImuo7xvCJoggmgUOszmzo3ao2MwOP9POr/XmUWbmPFlNVGI U0ng+Lrsxze5KZtkRoveGixhIw1ilNSvRqOEuJvrZQ== X-Google-Smtp-Source: ADUXVKKda61rIFin4ALo4U/sj9O6ooPxU2nDZa+03hXZeOKZC41olx39Taq1wXdSiNVvHurj95Z/CRAW9PWt1w4fGUI= X-Received: by 2002:a6b:1c87:: with SMTP id c129-v6mr18604964ioc.39.1528057528206; Sun, 03 Jun 2018 13:25:28 -0700 (PDT) MIME-Version: 1.0 References: <201806030507.w5357kMm036583@repo.freebsd.org> In-Reply-To: <201806030507.w5357kMm036583@repo.freebsd.org> From: Warner Losh Date: Sun, 3 Jun 2018 14:25:16 -0600 Message-ID: Subject: Re: svn commit: r334552 - head/usr.bin/top To: Eitan Adler Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jun 2018 20:25:29 -0000 Also, this is a mistake. You should put it back in. Warner On Sat, Jun 2, 2018, 11:07 PM Eitan Adler wrote: > Author: eadler > Date: Sun Jun 3 05:07:46 2018 > New Revision: 334552 > URL: https://svnweb.freebsd.org/changeset/base/334552 > > Log: > top(1): remove chdir to / > > While this came out of a conversation in IRC, it turn out that some > people don't like it. Since this was a courtesy feature, just remove it. > > Modified: > head/usr.bin/top/top.c > > Modified: head/usr.bin/top/top.c > > ============================================================================== > --- head/usr.bin/top/top.c Sun Jun 3 05:07:39 2018 (r334551) > +++ head/usr.bin/top/top.c Sun Jun 3 05:07:46 2018 (r334552) > @@ -260,15 +260,6 @@ main(int argc, char *argv[]) > #define CMD_order 26 > #define CMD_pid 27 > > - /* > - * Since top(1) is often long running and > - * doesn't typically care about where its running from > - * chdir to the root to allow unmounting of its > - * original wd. Failure is alright as this is > - * just a courtesy for users. > - */ > - chdir("/"); > - > /* set the buffer for stdout */ > #ifdef DEBUG > extern FILE *debug; > >