From owner-cvs-src-old@FreeBSD.ORG Wed Nov 11 15:43:23 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F34B1065698 for ; Wed, 11 Nov 2009 15:43:23 +0000 (UTC) (envelope-from jh@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8D7AB8FC1C for ; Wed, 11 Nov 2009 15:43:23 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id nABFhNWY082972 for ; Wed, 11 Nov 2009 15:43:23 GMT (envelope-from jh@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id nABFhNqj082971 for cvs-src-old@freebsd.org; Wed, 11 Nov 2009 15:43:23 GMT (envelope-from jh@repoman.freebsd.org) Message-Id: <200911111543.nABFhNqj082971@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to jh@repoman.freebsd.org using -f From: Jaakko Heinonen Date: Wed, 11 Nov 2009 15:43:07 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/fs/nfsclient nfs_clvnops.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2009 15:43:23 -0000 jh 2009-11-11 15:43:07 UTC FreeBSD src repository Modified files: sys/fs/nfsclient nfs_clvnops.c Log: SVN rev 199189 on 2009-11-11 15:43:07Z by jh Create verifier used by FreeBSD NFS client is suboptimal because the first part of a verifier is set to the first IP address from V_in_ifaddrhead list. This address is typically the loopback address making the first part of the verifier practically non-unique. The second part of the verifier is initialized to zero making its initial value non-unique too. This commit changes the strategy for create verifier initialization: just initialize it to a random value. Also move verifier handling into its own function and use a mutex to protect the variable. This change is a candidate for porting to sys/nfsclient. Reviewed by: jhb, rmacklem Approved by: trasz (mentor) Revision Changes Path 1.15 +25 -14 src/sys/fs/nfsclient/nfs_clvnops.c