From owner-freebsd-fs@FreeBSD.ORG Thu Jul 30 13:21:27 2009 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B5331065679; Thu, 30 Jul 2009 13:21:27 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (skuns.zoral.com.ua [91.193.166.194]) by mx1.freebsd.org (Postfix) with ESMTP id E677F8FC1E; Thu, 30 Jul 2009 13:21:26 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n6UDLMnG014222 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 30 Jul 2009 16:21:22 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n6UDLLS7015018; Thu, 30 Jul 2009 16:21:21 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n6UDLLY7015017; Thu, 30 Jul 2009 16:21:21 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 30 Jul 2009 16:21:21 +0300 From: Kostik Belousov To: Rene Ladan Message-ID: <20090730132121.GH1884@deviant.kiev.zoral.com.ua> References: <200907271400.n6RE05Rv056472@freefall.freebsd.org> <200907290742.20838.jhb@freebsd.org> <200907291135.17569.jhb@freebsd.org> <20090730092507.GF1884@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9A1A73/U17WN0PFw" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-fs@freebsd.org Subject: Re: kern/136945: [ufs] [lor] filedesc structure/ufs (poll) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2009 13:21:28 -0000 --9A1A73/U17WN0PFw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 30, 2009 at 02:55:48PM +0200, Rene Ladan wrote: >=20 > FreeBSD 8.0-BETA2 #3: Thu Jul 30 13:29:46 CEST 2009 >=20 > lock order reversal: > 1st 0xffffff00510a5d80 ufs (ufs) @ /usr/src/sys/kern/kern_exec.c:570 > 2nd 0xffffff0002dfe248 filedesc structure (filedesc structure) @ /usr/sr= c/sys/kern/kern_descrip.c:1864 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2a > _witness_debugger() at _witness_debugger+0x49 > witness_checkorder() at witness_checkorder+0x7ea > _sx_xlock() at _sx_xlock+0x44 > setugidsafety() at setugidsafety+0x40 > kern_execve() at kern_execve+0xf22 > execve() at execve+0x38 > syscall() at syscall+0x1af > Xfast_syscall() at Xfast_syscall+0xe1 > --- syscall (59, FreeBSD ELF64, execve), rip =3D 0x8007c3d0c, rsp =3D 0x7= fffffffec48, rbp =3D 0x7fffffffed50 --- For this one, please replace the order of lines 676 and 677 in sys/kern/kern_exec.c, that is make it be VOP_UNLOCK(imgp->vp, 0); setugidsafety(td); instead of VOP_UNLOCK(imgp->vp, 0); setugidsafety(td); --9A1A73/U17WN0PFw Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEUEARECAAYFAkpxnlEACgkQC3+MBN1Mb4iQdACfcPg7eF9peTrsew6tkY65XfFY cOYAl2sGeCOh/N1xLW+hsf1oEXkv454= =PmIC -----END PGP SIGNATURE----- --9A1A73/U17WN0PFw--