From owner-freebsd-emulation@FreeBSD.ORG  Fri Apr 29 17:31:22 2005
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: freebsd-emulation@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8331016A4CE; Fri, 29 Apr 2005 17:31:22 +0000 (GMT)
Received: from gwyn.kn-bremen.de (gwyn.kn-bremen.de [212.63.36.242])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DB62943D53; Fri, 29 Apr 2005 17:31:20 +0000 (GMT)
	(envelope-from nox@saturn.kn-bremen.de)
Received: from gwyn.kn-bremen.de (gwyn [127.0.0.1])j3THVHk8010725;
	Fri, 29 Apr 2005 19:31:17 +0200
Received: from saturn.kn-bremen.de (uucp@localhost)j3THVHWe010722;
	Fri, 29 Apr 2005 19:31:17 +0200
Received: (from nox@localhost)
	by saturn.kn-bremen.de (8.11.4/8.8.5) id j3THSqj47962;
	Fri, 29 Apr 2005 19:28:52 +0200 (CEST)
From: Juergen Lock <nox@jelal.kn-bremen.de>
Date: Fri, 29 Apr 2005 19:28:51 +0200
To: Jung-uk Kim <jkim@niksun.com>
Message-ID: <20050429192851.A47512@saturn.kn-bremen.de>
Mail-Followup-To: Jung-uk Kim <jkim@niksun.com>,
	freebsd-amd64@freebsd.org, freebsd-emulation@freebsd.org
References: <20050427210405.A95072@saturn.kn-bremen.de>
	<20050428210246.A21966@saturn.kn-bremen.de>
	<200504281514.01411.jkim@niksun.com> <200504290313.18498.jkim@niksun.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 1.0pre3i
In-Reply-To: <200504290313.18498.jkim@niksun.com>
cc: freebsd-emulation@freebsd.org
cc: freebsd-amd64@freebsd.org
Subject: Re: please test qemu port update
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>,
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>,
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Apr 2005 17:31:22 -0000

On Fri, Apr 29, 2005 at 03:13:15AM -0400, Jung-uk Kim wrote:
> On Thursday 28 April 2005 03:14 pm, Jung-uk Kim wrote:
> > On Thursday 28 April 2005 03:02 pm, Juergen Lock wrote:
>[...]

> > > Or is this a difference between i386 and amd64?
> >
> > I believe Makefile.target is doing something wrong but I haven't
> > found it yet.  I believe the culprit is Makefile.target not
> > checking ARCH == amd64 but x86_64.  In fact, it works perfect for
> > i386.
> 
> Yup, that's it.  MAKE_ENV was overriding ARCH==x86_64 in QEMU's 
> makefiles.
> 
Yeah looks like after .if !defined(NOPRECIOUSMAKEVARS) in
/usr/ports/Mk/bsd.port.mk...

> > > And if it really is, I would prefer setting the right variables
> > > (like USE_GMAKE, see /usr/ports/Mk/bsd.port.mk) instead of simply
> > > overriding the do-* targets.
> >
> > I'd love to find it out.  I will let you know when I get that
> > right.
> 
> The final patch (I hope) is attached.  This version includes few minor 
> fixes too.
> 
> I think it is commitable now.

 I found one small bug,

Index: Makefile
@@ -39,6 +39,8 @@
 BUILD_DEPENDS+=	gcc34:${PORTSDIR}/lang/gcc34
 GCCVERSION=	030402
 CC=		gcc34
+.else
+USE_GCC=	3.4
 .endif
 .else
 USE_GCC=	3.4

(tho it probably doesnt matter as i doubt there's an amd64 branch
that uses an older gcc than 3.4...)

 Any commiters here, or should i still send-pr?

	Juergen