From owner-freebsd-ports@FreeBSD.ORG Wed Feb 9 15:25:07 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 01798106566C for ; Wed, 9 Feb 2011 15:25:06 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 73E188FC08 for ; Wed, 9 Feb 2011 15:25:06 +0000 (UTC) Received: by ewy24 with SMTP id 24so143686ewy.13 for ; Wed, 09 Feb 2011 07:25:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=wI8iagZCrz11CT0tPD8NqJtZ+LLGy+c1TBR/rLSqM1g=; b=W/3sthxA/wf6eQOi5BxMDUKJ6SKIMApGypMOkeJ23rE1ItOoBTPoP7Pfea29TB4gds Vg+wu+Vo9m7LVj/ZBF3WKH1HHnvxL3FlSUq/7ZMlCc5QpZ0UZcUjQzB7V8YPJkH7iZRV Vg24OuaupSizHZFWMKW304becYnqp7hy8Er+w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; b=jz2mPc7up0+nJ58zqw5yrU4TtoWtdLydOhIv9WDC2SLglhUuXvPPdNDLAkdTvrvQ1T 6XiK4RGXaeKhOatmBsMLemXklmKlLhpZDSGZTSUViMZhL+KX4ioNgJpEATtD1gzcnGq9 iM2AE94zatp6maofdNyxGFouwTYQH9OUXTZzg= Received: by 10.213.4.135 with SMTP id 7mr1978444ebr.52.1297265094302; Wed, 09 Feb 2011 07:24:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.213.10.81 with HTTP; Wed, 9 Feb 2011 07:24:34 -0800 (PST) In-Reply-To: References: From: arrowdodger <6yearold@gmail.com> Date: Wed, 9 Feb 2011 18:24:34 +0300 Message-ID: To: Sunpoet Hsieh , freebsd-ports@freebsd.org, lists@eitanadler.com Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: Re: Request for new port review: TortoiseHG. X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2011 15:25:07 -0000 On Wed, Feb 9, 2011 at 4:42 PM, Sunpoet Hsieh wrote: > It looks like you'll have two ports, version 1 and 2, and these two > ports do not conflict with each other. > IMHO, I would simply use devel/tortoisehg1 for version 1 and > devel/tortoisehg for upcoming version 2. > You do not need to add -gtk or -pyqt suffix to emphasize the use of GTK or > Qt. > Okay. Now regarding this: > >> In your case, it can be done without extra patch files. > >> > >> .if !defined(WITH_NAUTILUS) > >> @${REINPLACE_CMD} -e '153,154 D' ${WRKSRC}/${PYSETUP} > >> .endif > >> .if !defined(WITH_NLS) > >> @${REINPLACE_CMD} -e '150,152 D' ${WRKSRC}/${PYSETUP} > >> .endif > -e 'x,y D' removes whole line, so all lines under removed line get shifted. So, it's impossible to apply them in all combinations. I'm not familiar with sed, but is it possible to delete whole line, but leave \n at the end so line numbers will not be shifted? PYDISTUTILS_EGGINFO defaults to > > ${PYDISTUTILS_PKGNAME:C/[^A-Za-z0-9.]+/_/g}-${PYDISTUTILS_PKGVERSION:C/[^A-Za-z0-9.]+/_/g}-${PYTHON_VERSION:S/thon//}.egg-info > (Mk/bsd.python.mk, around line 509) > > For Python versions, see PYTHON_VERSION, PYTHON_PORTVERSION and PYTHON_VER. > (Mk/bsd.python.mk, around line 372-410) > Okay, i will look there. By the way, currently 'make fetch' does not work, because hosting site have broken certs. So, i was forced to do this: RUN_DEPENDS= hg:${PORTSDIR}/devel/mercurial \ wget:${PORTSDIR}/ftp/wget FETCH_CMD=wget FETCH_BEFORE_ARGS=--no-check-certificate Is it ok? On Tue, Feb 8, 2011 at 10:11 PM, Eitan Adler wrote: > Hi, > Congrats on your first attempt! Here are a few issues with the port. > Please don't take them personally. > 1) install port-mgmt/portlint and run it on your port (portlint -CN) > it will point out a lot of things > 2) The preferred format for new ports is a shar - not a .tar.gz file > 3) It is not newline terminated > 4) the .egg-info files should not be included in the pkg-plist > 5) replace @dirrm lib/nautilus with @dirrmtry lib/nautilus because > your port does not directly create this directories > 6) And what i've been told is that i should use EXTRA_PATCHES, insteand of > invoking patch. --> yes. Please use a patch file unless it something > that has to be run on a significant number of files. reinplace makes > it harder to find out what is being patched. You may want to use 'make > makepatch' to generate them. > Eitan, thanks for your suggestions too.