From owner-svn-ports-head@FreeBSD.ORG  Fri Jun 21 01:22:10 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 69E37CA6;
 Fri, 21 Jun 2013 01:22:10 +0000 (UTC)
 (envelope-from swills@FreeBSD.org)
Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3])
 by mx1.freebsd.org (Postfix) with ESMTP id 323C810E7;
 Fri, 21 Jun 2013 01:22:10 +0000 (UTC)
Received: from meatwad.mouf.net (cpe-098-122-148-024.nc.res.rr.com
 [98.122.148.24]) (authenticated bits=0)
 by mouf.net (8.14.5/8.14.5) with ESMTP id r5L1LuSh043489
 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NOT);
 Fri, 21 Jun 2013 01:22:02 GMT (envelope-from swills@FreeBSD.org)
Message-ID: <51C3AAB3.4070301@FreeBSD.org>
Date: Fri, 21 Jun 2013 01:21:55 +0000
From: Steve Wills <swills@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130607 Thunderbird/17.0.6
MIME-Version: 1.0
To: Boris Samorodov <bsam@passap.ru>
Subject: Re: svn commit: r321372 - in head/sysutils/zxfer: . files
References: <201306201146.r5KBkVPM096679@svn.freebsd.org>
 <51C2F185.4080301@passap.ru>
In-Reply-To: <51C2F185.4080301@passap.ru>
X-Enigmail-Version: 1.5.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mouf.net [199.48.129.64]); Fri, 21 Jun 2013 01:22:02 +0000 (UTC)
X-Spam-Status: No, score=1.3 required=4.5 tests=RCVD_IN_RP_RNBL autolearn=no
 version=3.3.2
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mouf.net
X-Virus-Scanned: clamav-milter 0.97.8 at mouf.net
X-Virus-Status: Clean
Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org,
 Mark Felder <feld@feld.me>, ports-committers@FreeBSD.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Jun 2013 01:22:10 -0000

On 06/20/13 12:11, Boris Samorodov wrote:
> 20.06.2013 15:46, Steve Wills пишет:
>> Author: swills
>> Date: Thu Jun 20 11:46:31 2013
>> New Revision: 321372
>> URL: http://svnweb.freebsd.org/changeset/ports/321372
>>
>> Log:
>>   - Add ro properties for FreeBSD 9.1
>>   
>>   PR:		ports/178567
>>   Submitted by:	Mark Felder <feld@feld.me>
>>   Approved by:	maintainer timeout (ivannashdreckman@fastmail.fm, >4 weeks)
> [...]
>> + # Properties not supported on FreeBSD 8.2
>> +-fbsd_readonly_properties="aclmode,aclinherit,devices,nbmand,shareiscsi,vscan,xattr"
>> ++fbsd_readonly_properties="aclmode,aclinherit,devices,nbmand,shareiscsi,vscan,xattr,refcompressratio,written"
> -----
> 
> Something is not consistent here (9.1 vs 8.2).
> 

Yes, I think the comment is wrong, but the code is right. As Mark said
in another mail:

> zxfer hasn't been updated since 8.x days. Those are all known ro
attributes for 8.2. Adding *more* ro attributes won't hurt if you're
running on 8.x. However, not having all possible FreeBSD ro attributes
means that port is "broken" on >8.2 as it would not run on 8.4 now with
newer zfs code.

Steve