From owner-cvs-src-old@FreeBSD.ORG  Thu Aug 20 10:57:34 2009
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 023C31065693
	for <cvs-src-old@freebsd.org>; Thu, 20 Aug 2009 10:57:34 +0000 (UTC)
	(envelope-from avg@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id E519C8FC72
	for <cvs-src-old@freebsd.org>; Thu, 20 Aug 2009 10:57:33 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n7KAvXaR018085
	for <cvs-src-old@freebsd.org>; Thu, 20 Aug 2009 10:57:33 GMT
	(envelope-from avg@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n7KAvXcm018084
	for cvs-src-old@freebsd.org; Thu, 20 Aug 2009 10:57:33 GMT
	(envelope-from avg@repoman.freebsd.org)
Message-Id: <200908201057.n7KAvXcm018084@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	avg@repoman.freebsd.org using -f
From: Andriy Gapon <avg@FreeBSD.org>
Date: Thu, 20 Aug 2009 10:57:14 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/usr.bin/fstat fstat.c zfs.c
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Aug 2009 10:57:34 -0000

avg         2009-08-20 10:57:14 UTC

  FreeBSD src repository

  Modified files:
    usr.bin/fstat        fstat.c zfs.c 
  Log:
  SVN rev 196399 on 2009-08-20 10:57:14Z by avg
  
  fstat: fix fsid comparison when executed on systems with 64-bit long
  
  This affects only fstat on zfs and devfs, only on 64-bit systems
  and only when fsid is greater than 2^31 - 1.
  When fstat examines a file via stat(2) it takes uint32_t st_dev
  and assigns to (signed) (64-bit) long fsid, this results in
  a positive value.
  When fstat examines opened files it takes int32_t f_fsid.val[0]
  and assigns to (signed) (64-bit) long fsid, this results in
  a negative value.
  So, while initially st_dev and f_fsid.val[0] have the same bit
  values they get promoted to different 64-bit values because
  of the signed-vs-unsigned difference.
  
  A fix is to use "more natural" positive numbers by introducing
  intermediate unsigned cast for f_fsid.val[0].
  
  Reviewed by:    jhb, lulf
  Approved by:    re (kib)
  MFC after:      1 week (to stable/7)
  
  Revision  Changes    Path
  1.72      +1 -1      src/usr.bin/fstat/fstat.c
  1.9       +1 -1      src/usr.bin/fstat/zfs.c