From owner-svn-src-all@freebsd.org Wed Mar 8 22:46:43 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D63DD03BA3; Wed, 8 Mar 2017 22:46:43 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C952B10FD; Wed, 8 Mar 2017 22:46:42 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x242.google.com with SMTP id j5so5133968pfb.3; Wed, 08 Mar 2017 14:46:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=CDlmqSWrnkTKdUci134wcSHBXAsAopys4Cut8RkmxOk=; b=jBIeLLYaTiBUC4HaaKxK7KLlYK9xyJbJq9dq1iIiPvJGNela0jG/RtkS8kKfiJ7Krn kNFKLVysAg9V4Kt5M9m6Tnyew5wHy0Oifpz+MqTU76yWJUMWm4T9TObI7o+iTyg5Q45W i0nfULmdG9VlbJZMfbg4pMJ4BmjCXzfd6eKrZhuaW9HQZDtRvtLvVW/zLhw63a16Q/1M ZT/qONCoecUxU0LJTit/W1uJyJ3PnFbmzltovQB1+tyxHuG7+Zc6gJ1rPiGxqduWo/bx 8WHrFmNIKkR6/Aym7oHAOwv1b9Kl4v1MMJjyyyYAQWZfEt9R4oPSaAoqvgtidyNZGLw9 TymQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=CDlmqSWrnkTKdUci134wcSHBXAsAopys4Cut8RkmxOk=; b=q1dBuUX2N0sSw+9bpWqYVi36xY/zwOfy6Nx5wl76VtNtvKrWPx4CCH76o37DOWbNUS oCzmXkCaVJG9cU4MG9BEp33dRrYAD06OejgR24URyh9I9xnp/UdaV4PZXDIBS1zC9nlv nfNBc07obwKdoGJSxxOPCuNhBSpBfIjOdIN7yPcYHUgrYwb6A0bjwKaFFgynH241hr8i voKu3dlReyKBV4q9wlnF+x4C9Ogi86LMzvBBtLI3s+ELJ7KpSaOLedTWqz8hu7Uv+z4L ukWnH5UxotydhFhHNf6zIEi+7soEJUDt+aB+S2eNnDV6o+hTcerSWpYix9Kxa0dPHY0J InzA== X-Gm-Message-State: AMke39mZXHMuNbUN0gn6tyOp+Y2O6oviq2Qnq8tNRezqTbNKyOo26c30b+y/R6YhRTiNVA== X-Received: by 10.84.171.195 with SMTP id l61mr12037305plb.84.1489013202060; Wed, 08 Mar 2017 14:46:42 -0800 (PST) Received: from ?IPv6:2607:fb90:837c:20cb:3584:6f9e:56f6:7a7f? ([2607:fb90:837c:20cb:3584:6f9e:56f6:7a7f]) by smtp.gmail.com with ESMTPSA id m21sm8173032pgh.4.2017.03.08.14.46.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Mar 2017 14:46:41 -0800 (PST) Content-Type: text/plain; charset=cp932 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r314862 - head/sys/modules/qlxgbe From: Ngie Cooper X-Mailer: iPhone Mail (14D27) In-Reply-To: <20170308223908.GR1044@FreeBSD.org> Date: Wed, 8 Mar 2017 14:46:40 -0800 Cc: Andriy Gapon , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201703071543.v27FhnoL024242@repo.freebsd.org> <20170307221733.GN1044@FreeBSD.org> <70fcdcf4-cfa5-2382-ea60-55ac1a91e06b@FreeBSD.org> <20170308215514.GQ1044@FreeBSD.org> <20170308223908.GR1044@FreeBSD.org> To: Gleb Smirnoff X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 22:46:43 -0000 > On Mar 8, 2017, at 14:39, Gleb Smirnoff wrote: >=20 > On Wed, Mar 08, 2017 at 01:57:32PM -0800, Ngie Cooper (yaneurabeya) wrote:= > N> > On Wed, Mar 08, 2017 at 01:00:30AM +0200, Andriy Gapon wrote: > N> > A> On 08/03/2017 00:17, Gleb Smirnoff wrote: > N> > A> > On Tue, Mar 07, 2017 at 03:43:49PM +0000, Andriy Gapon wrote: > N> > A> > A> Author: avg > N> > A> > A> Date: Tue Mar 7 15:43:49 2017 > N> > A> > A> New Revision: 314862 > N> > A> > A> URL: https://svnweb.freebsd.org/changeset/base/314862 > N> > A> > A> > N> > A> > A> Log: > N> > A> > A> qlxgbe: add GCC_MS_EXTENSIONS to CFLAGS to make old base GC= C happy > N> > A> > A> > N> > A> > A> The module uses unnamed structure and union fields and base= GCC in > N> > A> > A> stable/10 doesn't like it. > N> > A> > A> I think that that is a C11 feature, so it is courteous of m= ore modern > N> > A> > A> compilers to not complain about it when compiling in C99 mo= de. > N> > A> > > N> > A> > There are a lot of code in kernel, that uses anonymous structs a= nd unions. > N> > A> > This feature is enabled globally. Why does this module need spec= ial treatment? > N> > A> > N> > A> That's a good question and I don't have a good answer to it. > N> > A> All I can say is that a GCC build of GENERIC and modules failed in= that fashion > N> > A> only for this module (in stable/10). > N> > A> Maybe I described the problem incorrectly. Then, a proper explana= tion is welcome. > N> >=20 > N> > In head this is fixed properly: > N> >=20 > N> > https://svnweb.freebsd.org/base?view=3Drevision&revision=3D278913 > N> >=20 > N> > Can you please move your fix to stable/10 and revert it in head? > N>=20 > N> I understand there might be conflicts, but wouldn=81ft it be better to r= evert and MFC the change you committed to ^/head (which is already in ^/stab= le/11) to ^/stable/10? >=20 > Could be. But I intentionally avoided MFCing it back in 2015, in my humble= > opinion changing global compilation flags is something not for a stable > branch. I defintely won't go for it, but anybody else welcome :) Looking at the number of changed makefilea/drivers again, I agree with your d= iscretion, but I do wonder if some of the failures on ^/stable/10 are caused= by this lack of support (on 2nd tier platforms like arm). It makes it ever s= o important for people backporting changes to be careful... Also, any changes avg@ makes should be backported to ^/stable9 because the d= river was backported there (and because clang isn't in the source tree there= IIRC -- I don't remember exactly since I haven't used 9.x for 6+ months). Thanks, -Ngie=