From nobody Mon Jul 22 18:55:03 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WSTx74GRpz5Pxyy; Mon, 22 Jul 2024 18:55:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WSTx73WFhz4PmH; Mon, 22 Jul 2024 18:55:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721674507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AegOR7ekMFPoFmj+S8GuvN+MLxpbMsjQANOb4wr74Ss=; b=Q6O2xTKMVCmViE0JdhUWDl75B5AE3eWjoHX1SWeh1LWItNiow8txgayTKnoRggaRLauqBq ecQNSxXrpKFg7rIM6qW7/ENtbpl1JJXSCLmVVXsqw4Ou+zei/+cESDrtruDSuk6Kq5cOIm 5+T5wzBvtv8oLwNRxOUh/k06b93FprCIW7Hl4UjX9Np7ZbNyUmLmmUTplIA2EwjEXlf9/R lR4eL34s4GT+sIYqEDMSkip+bR7wz+o4B1tekfMsGpsE1YEAHiBGCNOPolcaJul98BgkGY ftAvOAr92S8TWPmvPi56TLD79NAfIxi5lK0VUxqAExEOJhjBP7I2i/xeVMksmQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1721674507; a=rsa-sha256; cv=none; b=Ubqk9xOcpHHiS8Lrav9S3xvPWu0IdGWSyjm5mVHxTCVRcCnexwRYTwxogp9b9zfVGXjTWz sPHvwj17Jn2mWUD9Gg1E3zaKkcOiIn9sriRoLhOox+xvbRtDMv1GA0Zi1VLDTXrQXDFs5J +HvDwiYYlvUVCqauFZvkVcD6BQ4egVqM8rrIo+fHqYXUmHIiG6OlQQoTcLHY9zPxI2U9rq g3Ae/vyyYk/jmtgTx98DoS3jccEY5IrhN2RPQ7O2u7+3V5xCExlq9Z8GZIBdRzWylZIdxN QMMQs9FPBlQ7YxOH+Z5bZNDWOR2T16gedYZ/wpa74Bom/tN+NwbyjdROLmUs9w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721674507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AegOR7ekMFPoFmj+S8GuvN+MLxpbMsjQANOb4wr74Ss=; b=FEn2z85ZSVr7bIsCNtr1WPnkhIb8vfXYJiAjG/byKeB2fr+Fknr2jbBlNUoSMBm+ULZQPn /wf4foX9vyYWytyzJEdbdoCdP1ahmuhYVvLcmJKyu+Ox95t5PW17v6Goyv8emBZXDSMa1m r1NFdo+ZLrQx6bwhmYD3JKWciNGXDQDOyGrBhhIi1GTtM/ZdpHC8m1xYzVEu5ztORDwhuY Ns2hhUVAP1zHi8csACUHPRu4JFdnNEG55IEsMI45gffnON6VmHYWw4pV8YQgUywKMY1zKN hlzzbv8iKgmtlEChCWsXbind6uNDWZWMoPJfK2qxEaSTL7eBl7Yp2FFLvVBzTw== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E5" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WSTx726MWzjS7; Mon, 22 Jul 2024 18:55:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 9AFFCA64808; Mon, 22 Jul 2024 18:55:04 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 672862D029D8; Mon, 22 Jul 2024 18:55:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id nliK2pKPRak0; Mon, 22 Jul 2024 18:55:04 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:b66b:fcff:fef3:e3d2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 6F7F22D029D2; Mon, 22 Jul 2024 18:55:04 +0000 (UTC) Date: Mon, 22 Jul 2024 18:55:03 +0000 (UTC) From: "Bjoern A. Zeeb" To: Vladimir Kondratyev cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a1181662d370 - main - LinuxKPI: Add devm_device_add_group to linux/device.h In-Reply-To: <202407211314.46LDEoW4023107@gitrepo.freebsd.org> Message-ID: <0964qqop-qrsn-2rpq-1n4s-snr76ps12no9@SerrOFQ.bet> References: <202407211314.46LDEoW4023107@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Sun, 21 Jul 2024, Vladimir Kondratyev wrote: > The branch main has been updated by wulf: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a1181662d3707d8165d7153a0aa5d76ea1ddc11a > > commit a1181662d3707d8165d7153a0aa5d76ea1ddc11a > Author: Vladimir Kondratyev > AuthorDate: 2024-07-21 13:09:12 +0000 > Commit: Vladimir Kondratyev > CommitDate: 2024-07-21 13:09:12 +0000 > > LinuxKPI: Add devm_device_add_group to linux/device.h > > devm_device_add_group creates a managed attribute group for a device. > > Sponsored by: Serenity Cyber Security, LLC > MFC after: 1 week > Reviewed by: manu > Differential Revision: https://reviews.freebsd.org/D45845 > --- > sys/compat/linuxkpi/common/include/linux/device.h | 4 +++ > sys/compat/linuxkpi/common/src/linux_compat.c | 30 +++++++++++++++++++++++ > 2 files changed, 34 insertions(+) > > diff --git a/sys/compat/linuxkpi/common/include/linux/device.h b/sys/compat/linuxkpi/common/include/linux/device.h > index 00c55b31b248..912be8fbae8b 100644 > --- a/sys/compat/linuxkpi/common/include/linux/device.h > +++ b/sys/compat/linuxkpi/common/include/linux/device.h > @@ -701,4 +701,8 @@ int lkpi_devm_add_action_or_reset(struct device *dev, void (*action)(void *), vo > #define devm_add_action_or_reset(dev, action, data) \ > lkpi_devm_add_action_or_reset(dev, action, data) > > +int lkpi_devm_device_add_group(struct device *dev, const struct attribute_group *group); > +#define devm_device_add_group(dev, group) \ > + lkpi_devm_device_add_group(dev, group) I thought we would use linuxkpi_ as prefix for publicly exposed LinuxKPI related functions and lkpi_ for "internal" FreeBSD specific code which does not follow Linux KPI? Can this be fixed before MFC? -- Bjoern A. Zeeb r15:7