From owner-freebsd-hackers@freebsd.org Thu Aug 29 15:13:07 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4E772D9120; Thu, 29 Aug 2019 15:13:07 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46K5hf10pQz3KRk; Thu, 29 Aug 2019 15:13:05 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-lf1-x132.google.com with SMTP id r134so1925338lff.12; Thu, 29 Aug 2019 08:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=h0QMz+Lm8FEUOwvzCgeLbqnlJx+2a0mAxRB2YpPElmc=; b=oeml8Be48kyt6U9nTOFc6KyjbIdOcnb3Q+4/ZzNCUn3tbB5g7n7qrKhGrPD21RqJEv Bo+EdopkKyhIR6Gt0u1wiJF+AkzHVZ56/7rY8z9svqj6YXyA4DpdB+YNFusLD8cWf8sJ Wf0YArIZ1tG0mNOKHH53j05ICTlqQkNc/3IKZ/5fHoqFcJrnHJte6Wf+bNi7K2gMSjFt cugSXQX0/4RWEK6Y/AApgynYB2SQG5D9HDOCgfLO2QX0jQTsCxZ7+paZDd2WU5Jb6zre nUv5sQ/mo5czl8hMwl0cNtxUieAaFBq9Jey4QhxQr1p0UWq+7k8HIUPHWTLtHyYfWfwc o6VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=h0QMz+Lm8FEUOwvzCgeLbqnlJx+2a0mAxRB2YpPElmc=; b=n+zW64dil5giiguJ/4THzlLPAB2YRq5xl7UIAcKLXNgr11d42Fuv4HriBbBXXjfSwM LQ78n6vDprJ84iUe2b7gyKrArIouqY/9tU0nnc/3m20vH3VKuL0sHs66rofaQydcud0z GxDhKk+XogMffN2QPvEUh6CXDvTw0ZB/0GnFGFsYgsuPFF3vmlIYSGthD3TMPtisXXnI S3yS6pO1MGmyJjBIERnXWvHUzuw166KdzfaLZ27qx2/vB25X8fa3uTlVVpAYopHH/tE+ UjT6aCIN6RdKbRgdQI+9Y6qUOLEwjio0XbNUMXTIdlG+pDOtIHMXVll0stXB/9XfkLLj OFxQ== X-Gm-Message-State: APjAAAVMaNd3mr5bgPZZDW2TvUb8n3GTEqAaLtphlNFZhGBv2BSyOffe pT3qZCINYBsa9MOhmweAdA1Qa1RRVRnGHYM0JJc= X-Google-Smtp-Source: APXvYqyBoaxALyIyxqXLD1UbhXziGmNMbQfbPUoEla3gz2Djnd5WeIp9kPMzsG7nr1DoZrK+pWwGtz+vZZ9x0L2n784= X-Received: by 2002:ac2:5485:: with SMTP id t5mr4501980lfk.27.1567091582825; Thu, 29 Aug 2019 08:13:02 -0700 (PDT) MIME-Version: 1.0 References: <20190829114057.GZ71821@kib.kiev.ua> <412537DD-D98F-4B92-85F5-CB93CF33F281@FreeBSD.org> <20190829144228.GA71821@kib.kiev.ua> In-Reply-To: Reply-To: araujo@freebsd.org From: Marcelo Araujo Date: Thu, 29 Aug 2019 23:12:51 +0800 Message-ID: Subject: Re: FCP 20190401-ci_policy: CI policy To: Warner Losh Cc: Marcelo Araujo , Kristof Provost , Konstantin Belousov , FreeBSD Hackers , Li-Wen Hsu , fcp@freebsd.org X-Rspamd-Queue-Id: 46K5hf10pQz3KRk X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=oeml8Be4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of araujobsdport@gmail.com designates 2a00:1450:4864:20::132 as permitted sender) smtp.mailfrom=araujobsdport@gmail.com X-Spamd-Result: default: False [-3.99 / 15.00]; HAS_REPLYTO(0.00)[araujo@freebsd.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCPT_COUNT_SEVEN(0.00)[7]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-9.54), ipnet: 2a00:1450::/32(-2.99), asn: 15169(-2.32), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2.3.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Aug 2019 15:13:07 -0000 Em qui, 29 de ago de 2019 =C3=A0s 23:10, Warner Losh escre= veu: > > > On Thu, Aug 29, 2019 at 9:09 AM Marcelo Araujo > wrote: > >> Em qui, 29 de ago de 2019 =C3=A0s 23:03, Kristof Provost >> escreveu: >> >> > On 29 Aug 2019, at 16:42, Konstantin Belousov wrote: >> > > On Thu, Aug 29, 2019 at 02:03:00PM +0200, Kristof Provost wrote: >> > >> There are, somewhat regularly, commits which break functionality, o= r >> > >> at >> > >> the very least tests. >> > >> The main objective of this policy proposal is to try to improve >> > >> overall >> > >> code quality by encouraging and empowering all committers to >> > >> investigate >> > >> and fix test failures. >> > > But this policy does not encourage, if anything. >> > > It gives a free ticket to revert, discouraging committers. >> > > >> > To provide a counterpoint here: my personal frustration right now is >> > that I=E2=80=99ve spent a good bit of time adding tests for pf and fix= ing bugs >> > for it, only to see the tests having to be disabled because of unrelat= ed >> > (to pf) changes in the network stack. >> > >> > Either through lack of visibility, or lack of time, or because people >> > assume pf tests failures must by definition be the responsibility of t= he >> > pf maintainer, these failures have not been investigated by anyone oth= er >> > than me, and I lack the time and subject matter expertise to fix them. >> > >> > I=E2=80=99m desperately afraid that if/when these bugs do get fixed we= =E2=80=99re >> > going to discover that other things have broken in the mean time, and >> > the tests are still going to fail, for different reasons. >> > >> > These are bugs. They=E2=80=99re the best case scenario for bug reports= even, >> > because they come with a reproduction case built-in, and yet they=E2= =80=99re >> > still not getting fixed. This too is discouraging. >> > >> > I=E2=80=99m open to alternative proposals for how to address that prob= lem, but >> > I don=E2=80=99t think that =E2=80=9Ccontinue on as we always have=E2= =80=9D is the correct >> > >> >> OK, because of PF that is sort of deprecated on FreeBSD and it need some >> new rules to make it workable, everybody else need to abdicate to some n= ew >> rules. Yes, right you are!!!! >> > > Let's take every opportunity to clarify community norms and turn it into = a > federal case. That's productive. > Yeah, that was my bad!!! Apologies for that if we still have time. Sorry for that. > > Warner > --=20 --=20 Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)