From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Mar 23 01:09:34 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 607F8FEB for ; Mon, 23 Mar 2015 01:09:34 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2AAD3F6 for ; Mon, 23 Mar 2015 01:09:34 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2N19Y43013380 for ; Mon, 23 Mar 2015 01:09:34 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 198379] net/liboping: Update to 1.8.0, Fix MASTER_SITES, WWW, Request MAINTAINER'ship Date: Mon, 23 Mar 2015 01:09:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch, patch-ready X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: portmaster@bsdforge.com X-Bugzilla-Status: Open X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 01:09:34 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198379 --- Comment #15 from Chris Hutchinson --- (In reply to Chris Hutchinson from comment #14) > (In reply to Kubilay Kocak from comment #3) > > Don't forget ncurses can come from Base *or* Ports. If you can support both, > > do so. If you can't, you still want to test both scenarios. > > Thank you very much for taking the time to review > this, Kubilay Kocak. > *curses is not an option, and as it is, it will happily > use whichever (base, or ports) is available. > > As to the COMMENT; I modified it so that it better > reflected the *current* features/functions. As the > original one [currently] "misses the mark". > > As to: > install-target v. ${STRIP_CMD} > install-strip wasn't honored (portlint complained) > but ${STRIP_CMD} made portlint happy. I'll remove > INSTALL_TARGET* as it's redundant. > > Thanks again, Kubilay Kocak! > > --Chris > (In reply to f0andrey from comment #12) > > (In reply to Chris Hutchinson from comment #9) > > >> 3) As per original review: STRIP_CMD should take place in post-install. > > >> There is still a pre-install: STRIP_CMD > > > > > > Tried that originally, but there were issues (see additional QA log for > > > details). > > > > This recording allows you to transfer strip of "pre-install:" in > > "post-install:" > > ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/liboping.so.0.2.11 > I submitted an updated svn diff to reflect the changes in > response to this comment. > But bugzilla crashed, complaining about being unable to > send an email to the maintainer (matt@peterson.org). > So I'm just replying again, in hopes bugzilla doesn't > crash this time. > > Thanks! > > --Chris Does this look alright now? Thanks! --Chris -- You are receiving this mail because: You are the assignee for the bug.