From owner-svn-ports-all@freebsd.org Fri Jun 2 17:23:01 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E8E08BFBBB8; Fri, 2 Jun 2017 17:23:01 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C725A6E87A; Fri, 2 Jun 2017 17:23:01 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id EA49C15DD3; Fri, 2 Jun 2017 17:23:00 +0000 (UTC) Date: Fri, 2 Jun 2017 17:23:00 +0000 From: Alexey Dokuchaev To: Sunpoet Po-Chuan Hsieh Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r442399 - in head/games/epiar: . files Message-ID: <20170602172300.GA80250@FreeBSD.org> References: <201706021543.v52Fhcha099180@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201706021543.v52Fhcha099180@repo.freebsd.org> User-Agent: Mutt/1.8.2 (2017-04-18) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2017 17:23:02 -0000 On Fri, Jun 02, 2017 at 03:43:38PM +0000, Sunpoet Po-Chuan Hsieh wrote: > New Revision: 442399 > URL: https://svnweb.freebsd.org/changeset/ports/442399 > > Log: > Convert to options target helper > > - Pet portlint: fix diff header of patch file > - Fix WWW > ... > @${MKDIR} ${STAGEDIR}${DOCSDIR} > - ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR} > + cd ${WRKSRC}/ && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR} Please don't do this: it's a gratuitous change, it was not mentioned in the commit log, and most importantly, it was OK as it was. Don't try to fix what ain't broken. Thank you, ./danfe