From owner-svn-ports-all@freebsd.org Sat May 20 09:12:35 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B03BFD755F9 for ; Sat, 20 May 2017 09:12:35 +0000 (UTC) (envelope-from jrm@ftfl.ca) Received: from mail-qk0-f171.google.com (mail-qk0-f171.google.com [209.85.220.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 689CE170A for ; Sat, 20 May 2017 09:12:34 +0000 (UTC) (envelope-from jrm@ftfl.ca) Received: by mail-qk0-f171.google.com with SMTP id u75so77161868qka.3 for ; Sat, 20 May 2017 02:12:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TQtKPmiI6Pd5PjFlfs5D+AX34EoJt42vEO61kH0UrMs=; b=JAodmGdBkbomC94FVL8m7amfxlxHDeMrFSwNwKCAWODOVe1DJ8/umDBW6fgJclNqGs QkQFMasWIfha+wbGv75M+vwCZetnUSEPYqNXBD5V8taLgp2V/Dn6i6YKZR03n0FicR4L GOJyOBvTNTfAxH/HoC70B6SzncYU9D/w9kJMbo9ry3J5xDWOjDsBHKkWzQNHKmfhDK9N E5KLiq4qp6tojfYdrGLpUVXrcgZ5yH+00ikikuV1Vb4vDc0A+lxdzbH8WEAeLSnmeI65 vUE8YkURW6ed36gHcNRqDmS1r/t03yLFXegW5AxR2uJlDhSbD7N5dmMdFDJuKZUq4mKF REoQ== X-Gm-Message-State: AODbwcCpXpP7NAGUFJ2Vmz2Ni8O9KvfOySgD21rsZ8XwwhBrOBHLJ6+A Ery/e4f4vebvXgOu X-Received: by 10.55.201.68 with SMTP id q65mr13653692qki.198.1495271203454; Sat, 20 May 2017 02:06:43 -0700 (PDT) Received: from phe.ftfl.ca.ftfl.ca (hlfxns017vw-142-68-129-158.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.129.158]) by smtp.gmail.com with ESMTPSA id c202sm6651348qke.65.2017.05.20.02.06.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 20 May 2017 02:06:42 -0700 (PDT) From: Joseph Mingrone To: Adam Weinberger Cc: Dan Langille , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r441282 - in head: . security security/acme.sh References: <201705200227.v4K2RjjG055940@repo.freebsd.org> <989C2BB0-AC4E-4C76-AB15-9F616A6EF392@adamw.org> Date: Sat, 20 May 2017 06:06:35 -0300 In-Reply-To: <989C2BB0-AC4E-4C76-AB15-9F616A6EF392@adamw.org> (Adam Weinberger's message of "Fri, 19 May 2017 21:43:46 -0600") Message-ID: <86d1b3lwx0.fsf@phe.ftfl.ca> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 May 2017 09:12:35 -0000 --=-=-= Content-Type: text/plain Adam Weinberger writes: >> On 19 May, 2017, at 20:27, Dan Langille wrote: >> Author: dvl >> Date: Sat May 20 02:27:45 2017 >> New Revision: 441282 >> URL: https://svnweb.freebsd.org/changeset/ports/441282 >> Log: >> A pure Unix shell script implementing ACME client protocol >> Differential Revision: https://reviews.freebsd.org/D10308 >> Added: >> head/security/acme.sh/ >> head/security/acme.sh/Makefile (contents, props changed) >> head/security/acme.sh/distinfo (contents, props changed) >> head/security/acme.sh/pkg-descr (contents, props changed) >> Modified: >> head/GIDs >> head/UIDs >> head/security/Makefile >> +RUN_DEPENDS= curl:ftp/curl >> + >> +OPTIONS_DEFINE= CURL DOCS WGET >> +OPTIONS_DEFAULT= CURL >> +CURL_DESC= Add ftp/curl as a run-time dependency >> +WGET_DESC= Add ftp/wget as a run-time dependency >> + >> +CURL_RUN_DEPENDS= curl:ftp/curl >> +WGET_RUN_DEPENDS= wget:ftp/wget > Hi Dan, > You have curl as a mandatory and optional dependency, which effectively makes curl mandatory. I think you want to use OPTIONS_SINGLE or OPTIONS_MULTI here, to make it an actual choice between the two of them. > Also the descriptions are a bit strange. I mean, it does add them as a dependency, but I think an end-user would be more concerned with what curl or wget does for acme.sh, no? > # Adam Hi Adam, Dan, The link below is a patch with proposed changes. http://ftfl.ca/misc/acme.sh-2.6.9.diff Changelog: - Add OPTION_SINGLE for choosing one of cURL or Wget for HTTP(s) queries - Update CURL/WGET descriptions [1] - Silence porlint warnings [1] They do not say "Use cURL/Wget...", because acme.sh will, by default, use cURL if both cURL and Wget are installed Joseph --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEVbCTpybDiFVxIrrVNqQMg7DW754FAlkgBxxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUACgkQNqQMg7DW 7564Cw/9EZeDpiJau9ruEgkGWbwndYNrAVsX71YeF20wCqIr+A631wcHGH0MABQF olGy2ToQVf4UekFv8s1YrE3WcNU+IjPwGu0XWlfQLwIzvVkS+SptWUrV62yyLVTA iibQ2aOwi6H4YcoNGoP/CfOpsi6q6fswU8GxTb2c8bD9LcC+pZG3FEz9bV94J0jM kYF3rssITckxvLIcTugvNrJjJHnzSIGeVGjERnP1KQlPA7APmm0pVOQBW324mxg/ 7XSlU2V6rEu2faLaVUckJ23N9+RsfmrSkGBe3BhQRv+AvWm1VidO1B3XFGPa3pqk jUqyDyTD3mWik+yMzKMPiURT5qC27jCu4caQezE/YS3FVovf9+549XUSoOjsKJJb ED9jBsGo4ClCxt6EapJaEDjR6E72zyfP4zSJ7W/cNlUuhW4O9dYcdWfXUhxbdGau XOsAWv+5/FGhXBkR8qu6dX4vNkeaGGXYbR4OvdX0DmsFbx0WyBMZcF35Cs/ptfYn x+HAnwzFNKRZ4iZVn1AXbAYnRYOYjff8B6iRpGMYb7M7JWj6iwLs5l4j/1YXtiqv KenhsRXzbY7/AGZha8qE1wGmFL/mSMN3RqwwdM6BuO9LK55fXLWx+iBm0fP3s4MK d6cVLOu9/+ilLe67a5X/R2ZRh9uaat6LtvQ01pFD2YYcZZkH1Y4= =Djsy -----END PGP SIGNATURE----- --=-=-=--