From nobody Sat Jan 20 19:39:58 2024 X-Original-To: gnome@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4THRdp5wD2z57Lml for ; Sat, 20 Jan 2024 19:39:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4THRdp4sZKz4lNr for ; Sat, 20 Jan 2024 19:39:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705779598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Z9To010piAgDvRKJWOp3Q6cPXHf0ZMhWgZqj5JNrYGU=; b=JVV6wLGelx0u+MYzEWX1NaopaE6I7WHtJf5l92yInpI40aCDrIQGiiYBTwyShVsOGz6Uwj 3ZgiDhOl30ZMfemm5a7yTzn4GvtqlEDlvEkNvPRiKDz6c9w0YNlcUT/XmeyHnYwSCSCWxG FtfMCPK6rlkOsKdk1bBwOtv/OUO2NW9SITzn1Ya0bAdv79E828liLg6KNfUQ1vV64wa2jQ ykwEDmn2TAFbr73/1HcqfpOPP9btRp+pvX5vSL4p6STYRXHpIzjtohRk9Gj7z8Iua5RBww fJLZS3Os/FHU4cOoyfvUrc1IakrTR6xROjbgtUPLOeWSty2d6gIgh1tNL1LOUA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705779598; a=rsa-sha256; cv=none; b=o7+iNQObGxk4As2KgyTPwbWdg0KTDZTZu1z9woH193pWP8WhHm0ZP+DRDxuWRI9Twppsiy 6NuggzHXodzYiXb4qKJHXuottBCALS/7KZZo5mZBFv8aFl7aNElRIfPijnZP4LPQ5WJh+F Cg+0FAs3HWoxgGiHYdsMVbF1MryQn3mAhqJnjtnV9fDV/tE7qi2gw8Bu91BXAlN9gb+qQM TDaiAdAedanwT65gf4Q8qUnjpasP/Eg27ZSVJMei62rDcKjmLWHj3AMTanpw9yrr+8k6u5 heh6FCweXADWMcFVIIcyg5uoRNxJzAW99kbZNv7W684KmiMqp+PsJ9y2oXun2w== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4THRdp3x2Vznd0 for ; Sat, 20 Jan 2024 19:39:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40KJdwja062504 for ; Sat, 20 Jan 2024 19:39:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40KJdwjH062502 for gnome@FreeBSD.org; Sat, 20 Jan 2024 19:39:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 276478] Mk/*: Build with a clean environment Date: Sat, 20 Jan 2024 19:39:58 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tijl@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: exp-run? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc blocked flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: GNOME for FreeBSD -- porting and maintaining List-Archive: https://lists.freebsd.org/archives/freebsd-gnome List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gnome@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276478 Bug ID: 276478 Summary: Mk/*: Build with a clean environment Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: tijl@FreeBSD.org CC: acm@FreeBSD.org, amdmi3@FreeBSD.org, gnome@FreeBSD.org, go@FreeBSD.org, haskell@FreeBSD.org, java@FreeBSD.org, kde@FreeBSD.org, olgeni@FreeBSD.org, perl@FreeBSD.org, ports-bugs@FreeBSD.org, python@FreeBSD.org, ruby@FreeBSD.org, rust@FreeBSD.org, x11@FreeBSD.org Blocks: 272216 Flags: exp-run? Created attachment 247801 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D247801&action= =3Dedit patch Both our make and gmake use the MAKEFLAGS environment variable but the valu= es aren't compatible and the latest version of gmake complains about that. To prevent that environment variables interfere with the build process like th= is, this patch adds a new command SETENVI=3D/usr/bin/env -i that clears the environment. The idea is to use SETENVI instead of SETENV when running bui= ld tools and scripts so their environment only contains variables from CONFIGURE_ENV or MAKE_ENV or TEST_ENV or similar. This way it doesn't matt= er what variables our make uses or what environment variables a user might have set. This patch takes care of Mk/* and Mk/Uses/*. Individual ports can be chang= ed later. If you are the maintainer of any of the Mk/Uses/* files please review the changes. A minor open problem is that the TERM environment variable is now missing w= hich means that error messages are no longer colored for instance. I'd like to introduce a new variable WRK_ENV that would contain common environment variables like TERM, PATH, and SHELL, and perhaps other variables that are common between CONFIGURE_ENV and MAKE_ENV. It would be used in every make target while CONFIGURE_ENV, MAKE_ENV, and TEST_ENV contain target specific environment variables. Any objections to this? Referenced Bugs: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272216 [Bug 272216] devel/gmake: Update to 4.4.1 --=20 You are receiving this mail because: You are on the CC list for the bug.=