Date: Thu, 6 Aug 2020 14:05:52 +0100 From: =?UTF-8?Q?Danilo_Eg=C3=AAa_Gondolfo?= <danilo@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Mateusz Piotrowski <0mp@freebsd.org>, ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r544245 - head/x11/sakura Message-ID: <CAFU7VyPPr9Wu=qCT2D5tNASbkk9Srgf6Z_gq2c_03v2DdzeZOQ@mail.gmail.com> In-Reply-To: <20200806125648.GA77959@FreeBSD.org> References: <202008052155.075LtmtD072730@repo.freebsd.org> <20200806033440.GA53929@FreeBSD.org> <CAFU7VyOkoJ2yp6Oz88Tfkhts0GzVPDfKXJnyTbfJmmRS0QhcJw@mail.gmail.com> <c30e03c9-1b8e-294b-c02c-14ada40f5d26@FreeBSD.org> <20200806125648.GA77959@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 6, 2020 at 1:56 PM Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Thu, Aug 06, 2020 at 01:50:09PM +0200, Mateusz Piotrowski wrote:
> > On 8/6/20 12:46 PM, Danilo Eg??a Gondolfo wrote:
> > > ...
> > > Just tried to make portlint happy on this one ("USES should appear
> > > earlier").
> >
> > Please try portfmt and portclippy from ports-mgmt/portfmt. They are
> > much better for order fixes and simple style fixes than portlint in
> > most cases.
>
> No matter which linter one prefers, please never blindly follow their
> diagnostics or advice without giving it sufficient thinking first.
>
> ./danfe
>
Fair enough, I might need to start revisiting our handbook more frequently.
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-order-uses.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFU7VyPPr9Wu=qCT2D5tNASbkk9Srgf6Z_gq2c_03v2DdzeZOQ>