From owner-svn-src-all@freebsd.org Thu May 7 18:04:07 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BFC682E01E5 for ; Thu, 7 May 2020 18:04:07 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49J1Yg07Jkz4Vmn for ; Thu, 7 May 2020 18:04:06 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f68.google.com with SMTP id w7so6653645wre.13 for ; Thu, 07 May 2020 11:04:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=9tyi3HTeM/onj+xSEcf7hulRwWWiv0NM+JqKBiFVSxY=; b=AMDIlVZAyc6upvfFaX/XgROetxpZIeyi4wCGdDc5dVJPL+n3SED0PoZP/GfZ3WnIws HSYtBaJFDMynywV/+NXLAtOelG3DqDdka/XSqUZ9hLBQkpPWnFKWqztq94nndKcmzRxH TQhdGwjAjJ0HxY4l+P9AYa4V8cxd7FhzqtlkvjqXdrGPjrWN5tnfYB/Zml4RkNoJILsn +bEUF9i9CNbTHe1i3012nLoWY2BWzpFncUIgiL6k4dB1Zc49s0YvAbRV8WvndHzkQ5WI BtnIQ72Qjh2XkJhArQiwMoNVS3epUK2bP8EoBTqgcbkmGI2n8Lamdo4rRNCPqsGD7Hgh bpmw== X-Gm-Message-State: AGi0PuavK/dWcqbmhS8DwcFckj/p+BjI0KE/IHuZhbjAxZQK4cIxAUsK fAYaJgkpMj1u1vKJk7kpKxpOqA== X-Google-Smtp-Source: APiQypLYyF8KKN/T7E4nZaausnEXtNCSfPpWnEnVxwR7OC9Y5NkJiqFuxc6SEYDUNQLKM4eguunJIQ== X-Received: by 2002:a05:6000:1048:: with SMTP id c8mr16112759wrx.1.1588874645299; Thu, 07 May 2020 11:04:05 -0700 (PDT) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id l5sm1882550wrr.72.2020.05.07.11.04.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 May 2020 11:04:04 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: svn commit: r360722 - head/sys/dev/virtio/mmio From: Jessica Clarke In-Reply-To: <20200507172530.GA61260@freefall.freebsd.org> Date: Thu, 7 May 2020 19:04:03 +0100 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <68E0E25D-759A-4D4C-895B-0AB98A3493C9@freebsd.org> References: <202005062328.046NSp8x079151@repo.freebsd.org> <20200507172530.GA61260@freefall.freebsd.org> To: Li-Wen Hsu X-Mailer: Apple Mail (2.3608.60.0.2.5) X-Rspamd-Queue-Id: 49J1Yg07Jkz4Vmn X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com X-Spamd-Result: default: False [-3.11 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[68.221.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; IP_SCORE(-1.61)[ip: (-7.18), ipnet: 209.85.128.0/17(-0.39), asn: 15169(-0.43), country: US(-0.05)]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[68.221.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 May 2020 18:04:07 -0000 On 7 May 2020, at 18:25, Li-Wen Hsu wrote: > On Wed, May 06, 2020 at 23:28:51 +0000, Jessica Clarke wrote: >> Author: jrtc27 >> Date: Wed May 6 23:28:51 2020 >> New Revision: 360722 >> URL: https://svnweb.freebsd.org/changeset/base/360722 >>=20 >> Log: >> virtio_mmio: Support non-transitional version 2 devices >>=20 >> The non-legacy virtio MMIO specification drops the use of PFNs and >> replaces them with physical addresses. Whilst many implementations = are >> so-called transitional devices, also implementing the legacy >> specification, TinyEMU[1] does not. Device-specific configuration >> registers have also changed to being little-endian, and must be = accessed >> using a single aligned access for registers up to 32 bits, and two >> 32-bit aligned accesses for 64-bit registers. >>=20 >> [1] https://bellard.org/tinyemu/ >>=20 >> Reviewed by: br, brooks (mentor) >> Approved by: br, brooks (mentor) >> Differential Revision: https://reviews.freebsd.org/D24681 >>=20 >> Modified: >> head/sys/dev/virtio/mmio/virtio_mmio.c >> head/sys/dev/virtio/mmio/virtio_mmio.h >=20 > Hi Jessica, >=20 > It looks this commit breaks armv6 and armv7 builds: >=20 >=20 > --- virtio_mmio.o --- > /usr/src/sys/dev/virtio/mmio/virtio_mmio.c:442:13: error: shift count = >=3D width of type [-Werror,-Wshift-count-overflow] > paddr >> 32); > ^ ~~ > /usr/src/sys/dev/virtio/mmio/virtio_mmio.c:127:44: note: expanded from = macro 'vtmmio_write_config_4' > VIRTIO_MMIO_PREWRITE(sc->platform, (o), (v)); \ > ^ > ... >=20 > https://ci.freebsd.org/job/FreeBSD-head-armv6-build/9109/console > https://ci.freebsd.org/job/FreeBSD-head-armv7-build/9035/console Thanks, yes, of course. This should be fixed as of r360789. Jess