From owner-freebsd-hackers@freebsd.org  Sat Dec 22 06:41:48 2018
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A20C11347564
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Sat, 22 Dec 2018 06:41:48 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B141D731B7
 for <freebsd-hackers@freebsd.org>; Sat, 22 Dec 2018 06:41:47 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id wBM6fdT3045291
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sat, 22 Dec 2018 08:41:42 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua wBM6fdT3045291
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id wBM6fc62045290;
 Sat, 22 Dec 2018 08:41:38 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Sat, 22 Dec 2018 08:41:38 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Yuri Pankov <yuripv@yuripv.net>
Cc: freebsd-hackers <freebsd-hackers@freebsd.org>
Subject: Re: is adding new private symbols to libc frowned upon?
Message-ID: <20181222064138.GM60291@kib.kiev.ua>
References: <e120678a-359b-5131-3866-219d4c3cd796@yuripv.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e120678a-359b-5131-3866-219d4c3cd796@yuripv.net>
User-Agent: Mutt/1.11.1 (2018-12-01)
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM,
 NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Dec 2018 06:41:48 -0000

On Sat, Dec 22, 2018 at 04:38:52AM +0300, Yuri Pankov wrote:
> Essentially, I need the __collate_equiv_value symbol to be visible to
> libregex for the changes in https://reviews.freebsd.org/D18531.  Is the
> following change OK (it works, at least), or should try to avoid that?
> 
> --- a/lib/libc/locale/Symbol.map
> +++ b/lib/libc/locale/Symbol.map
> @@ -212,6 +212,7 @@ FBSD_1.3 {
>  FBSDprivate_1.0 {
>         _PathLocale;
>         __detect_path_locale;
> +       __collate_equiv_value;
>         __collate_load_error;
>         __collate_range_cmp;
>  };
> 
Then libregex must always match the installed libc.

I looked at the the libregex/Makefile and my question is, what is the
difference between exports from libc/regex vs. libregex.  Can libregex
become ELF filter for libc ?