From owner-freebsd-elastic@freebsd.org Thu Feb 13 00:18:54 2020 Return-Path: Delivered-To: freebsd-elastic@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1DFB32470BE for ; Thu, 13 Feb 2020 00:18:54 +0000 (UTC) (envelope-from paulgodard@gmail.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48HxvK67vGz4CGZ for ; Thu, 13 Feb 2020 00:18:53 +0000 (UTC) (envelope-from paulgodard@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id D0EBF2470BD; Thu, 13 Feb 2020 00:18:53 +0000 (UTC) Delivered-To: elastic@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D0A762470BC for ; Thu, 13 Feb 2020 00:18:53 +0000 (UTC) (envelope-from paulgodard@gmail.com) Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48HxvJ67dxz4CGY for ; Thu, 13 Feb 2020 00:18:52 +0000 (UTC) (envelope-from paulgodard@gmail.com) Received: by mail-io1-xd2f.google.com with SMTP id s24so4438532iog.5 for ; Wed, 12 Feb 2020 16:18:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AJxUEQ4SJuxTYJ7vZWF0OEQ0BGUgbI9L7fUJjVuHoVM=; b=qWmxOwoZnuQbb79/Tb5Gh5GavkHF1aQHl/geQroiY0/gpwV+TzhSwVgQFfcExRhm+9 wynz3lh3Uc+sAoGfqYB8ilPdNF1kN5Y08vf64Ioq69/bVX7/sjxI7FI0f9dOi4+KZNj0 NJoYduJX5M5BPBVh6AB43Xh7MMAJjHz95Qok1KQ4LOJ0BBdIOStHavVXYD+SegZ2h0Zo 5L0J08vXdWtEQvqLQnF49yl5lR5laUlTumcY6cS3gwY53vdpT+agqEcCvD7ZGJivgvDK bSZNZaZAxvjm/pj1/rreuGR5vF0Tjbjj4tyvDmeS7pK0hUdIuYEahuVnwh4rla3k6j1P b4xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AJxUEQ4SJuxTYJ7vZWF0OEQ0BGUgbI9L7fUJjVuHoVM=; b=C8SNSQMU4qi3wOJzYqwUEcnSvVSQ+bjwVGeKUyjmaJokWAFdQ4Q8OehHbeTokH8InF dUjeu4IbWDSwEcmpmZbeyBFvqOx+oONHtLRkDtdZU8cSdWangnSke5sNnTqd2UabOF8W ZDRLB/Qz0jHCE0ZpLMcZHcv5UvWK14pDO7xNYKMOpjlMXCwVzWf/w5XJ12MnCRO8m9ev 0ilToFB0vrCjJWoyWJRuoiv+YMRXm2eKkXbMOXwL1yyjJBErFvPHpAZ8UGkDNnb7AWJ5 Qu5oEB3UjQNNJxGUzW4c+WEV4BGDhpSXPiwuveaYklJI3NK2gSMd21ltTRbGM6CTAMLf 5qvw== X-Gm-Message-State: APjAAAUvabh0ixYYh3ypN8FmWYOAZX018ZWYMrOEHYqQ47y1lrrQZPY5 2L3nSvuqZlYCS5zDTr/RVf1y3fNXS0zm0i+5ZgpIFnMo X-Google-Smtp-Source: APXvYqwem9E7FG1dt3tUI5wP9IXoVgD3G05TMdb+hJtp9OMs1woWNbi+8Fr9NlRytarr7j3/hbZt+uj51FB1O3foB7Q= X-Received: by 2002:a02:2404:: with SMTP id f4mr20555200jaa.50.1581553131612; Wed, 12 Feb 2020 16:18:51 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Paul Godard Date: Wed, 12 Feb 2020 19:18:39 -0500 Message-ID: Subject: Re: Beats port update - 7.5.2 To: Miroslav Lachman <000.fbsd@quip.cz> Cc: elastic@freebsd.org X-Rspamd-Queue-Id: 48HxvJ67dxz4CGY X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=qWmxOwoZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of paulgodard@gmail.com designates 2607:f8b0:4864:20::d2f as permitted sender) smtp.mailfrom=paulgodard@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[elastic@freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[f.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-6.44), ipnet: 2607:f8b0::/32(-1.92), asn: 15169(-1.70), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-elastic@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Support of ElasticSearch-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Feb 2020 00:18:54 -0000 Hi Miroslav, Thanks for the feedback. I'm polishing up the port right now and will submit a PR along with my poudriere testport logs shortly! Cheers, Paul On Tue, Feb 11, 2020 at 5:49 PM Miroslav Lachman <000.fbsd@quip.cz> wrote: > Paul Godard wrote on 2020/02/11 23:35: > > Hello maintainer(s)! > > > > I've been working on an update to the "beats" port for the past week or > so. > > I've upgraded it to version 7.5.2, and fixed a few things here and > there. I > > wanted to reach out to you as the maintainer(s) of the port to share my > > work and/or understand why you might have kept the current port on > version > > 6.x. > > > > I've been mainly testing PacketBeat and MetricBeat (on FreeBSD 11.2 and > > pfSense 2.4.4, which also happens to run FreeBSD 11.2), but also ensured > > that HeartBeat and FileBeat are working. I've shared this development > port > > with a few other folks just to get better testing results (all of these > > folks are testing this on pfSense 2.4.4 as well). Full disclosure, I > > haven't had the time to test this properly on up-to-date builds of > FreeBSD > > such as 11.3 or 12.x (my goal is to run this on pfSense so I've been > > focusing on FreeBSD 11.2 for that reason). I have compiled and packaged > the > > port on 11.3, but did not spend much time testing it other than ensuring > > each beats application starts up and actually pushes data to ES. > > > > My high-level change log is as follows: > > - Upgraded to 7.5.2 > > - Fixed warnings at compile time (fixed bash to sh test conditions) > > - Cleared up compile/package output (it was quite noisy, portlint doesn't > > like this though) > > - Fixed compile issue with PacketBeat (it's now compiling and working) > > - Fixed packaged dashboards so that they can be installed using "setup > > --dashboards" (depends on python 2.7 to achieve this during port > building - > > python isn't required to run packaged port however) > > - Properly generate and include fields.yml for each beats in package > > - Fixed memory and socket reporting in MetricBeats > > - Updated all beats paths to regroup files as per Elastic's default > > directory layout (but using the equivalent paths for FreeBSD) > > - Changed default beats configs to remove unsupported processors (docker > > and kubernetes) > > > > I'm still testing this port, but I feel like it's getting pretty close to > > being ready for prime-time. I've posted my current SVN diff here if you > > would like to take a peek at my changes: https://pastebin.com/PAQWpmKZ. > > > > Feel free to comment on my changes; I'm by no means an expert at these > > ports (I'm learning though!). If you feel this is good enough to submit a > > PR, let me know, I can take care of that once I'm comfortable with the > > build. Or if you prefer to submit the PR with my SVN diff as the > > maintainer(s), I have no problem with that either... > > Hello, > > first of all - I am not a maintainer. elastic@freebsd.org is a mailing > list account and is supposed to be Elastic maintainers team but it is > not much active. > > The best place to submit your patch for port upgrade is PR in bugzilla. > > Please submit it there: > > https://bugs.freebsd.org/bugzilla/enter_bug.cgi?product=Ports%20%26%20Packages&component=Individual%20Port%28s%29 > > If you tested it with poudriere testport attache log file too. > > I hope someone with commit bit will commit it soon. > > Thank you for your work in Beats upgrade to 7.5! > > Kind regards > Miroslav Lachman >