From owner-svn-src-all@FreeBSD.ORG  Mon Sep 15 10:50:06 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D9216EEA;
 Mon, 15 Sep 2014 10:50:06 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5BB31EEF;
 Mon, 15 Sep 2014 10:50:05 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id s8FAo2O1076655
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Mon, 15 Sep 2014 14:50:02 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id s8FAo24Z076654;
 Mon, 15 Sep 2014 14:50:02 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Mon, 15 Sep 2014 14:50:02 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Hans Petter Selasky <hselasky@FreeBSD.org>
Subject: Re: svn commit: r271504 - in head/sys: dev/oce dev/vmware/vmxnet3
 dev/xen/netfront net netinet ofed/drivers/net/mlx4
Message-ID: <20140915105002.GQ60617@FreeBSD.org>
References: <201409130826.s8D8Q9Wx078339@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201409130826.s8D8Q9Wx078339@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Sep 2014 10:50:07 -0000

  Hans,

  I second on Adrians suggestions.

Also, this chunk:

H> Modified: head/sys/netinet/tcp_output.c
H> ==============================================================================
H> --- head/sys/netinet/tcp_output.c	Sat Sep 13 07:45:03 2014	(r271503)
H> +++ head/sys/netinet/tcp_output.c	Sat Sep 13 08:26:09 2014	(r271504)
H> @@ -52,6 +52,7 @@ __FBSDID("$FreeBSD$");
H>  #include <sys/sysctl.h>
H>  
H>  #include <net/if.h>
H> +#include <net/if_var.h>
H>  #include <net/route.h>
H>  #include <net/vnet.h>

Is it possible to avoid this inclusion? I'd even suggest to push
all TSO (or all TCP hardware assistance stuff) into a separate
header, that is shared between TCP and drivers, w/o polluting
TCP with all ifnet knowledge.

-- 
Totus tuus, Glebius.