From owner-freebsd-ports@FreeBSD.ORG Tue May 26 02:15:48 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2406E106564A; Tue, 26 May 2009 02:15:48 +0000 (UTC) (envelope-from maho.nakata@gmail.com) Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.173]) by mx1.freebsd.org (Postfix) with ESMTP id D4C3B8FC17; Tue, 26 May 2009 02:15:47 +0000 (UTC) (envelope-from maho.nakata@gmail.com) Received: by wf-out-1314.google.com with SMTP id 24so1048752wfg.7 for ; Mon, 25 May 2009 19:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:date:message-id:to:cc :subject:from:in-reply-to:references:x-mailer:mime-version :content-type:content-transfer-encoding; bh=ns5CH6HyPqIwSUUoA6LeaKwI1GuCYFWdsZweGD0GQMw=; b=YpUYHl16vjUTmSR7KXZ1bbqW/d4l163beEiPCsaGZTPLw1A7pVp8yWpdkYaeZ6hcVw lr9B+UoBSxIqruxdDLN9ckeUAr/myKfUpk5lsF2IzlSj5h0c2JDAeYsyFjUd//Wf/6UE oEy9tdfWlWiJfHOQrd74DWjh9Kw0c1CFHleVs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:message-id:to:cc:subject:from:in-reply-to:references :x-mailer:mime-version:content-type:content-transfer-encoding; b=UXU9S9Usieo7rjXL1Dvk+Ad8wVvB1Sutfg9y0YhVtCRlkAqPqZWq9ADR2fHoQt+Due mRVJxSpb5Etvzo+GKYiez5EaEoKEwEMP8iln0TIMsr2xDQZ72JhDCFQIu6S6bWqAFMAN MK8Cq9E7NDEr0YWRZtxTgngs5hj9Tj8YZ6TAU= Received: by 10.142.240.9 with SMTP id n9mr2467276wfh.40.1243304147375; Mon, 25 May 2009 19:15:47 -0700 (PDT) Received: from localhost (rikad42.riken.jp [134.160.214.42]) by mx.google.com with ESMTPS id 24sm3360247wff.31.2009.05.25.19.15.44 (version=SSLv3 cipher=RC4-MD5); Mon, 25 May 2009 19:15:45 -0700 (PDT) Sender: Maho NAKATA Date: Tue, 26 May 2009 11:13:43 +0900 (JST) Message-Id: <20090526.111343.48515131.chat95@mac.com> To: naylor.b.david@gmail.com From: Maho NAKATA In-Reply-To: <200905252247.32725.naylor.b.david@gmail.com> References: <200905251003.15408.naylor.b.david@gmail.com> <20090525210125.1239c21e@it.buh.tecnik93.com> <200905252247.32725.naylor.b.david@gmail.com> X-Mailer: Mew version 6.2 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Tue_May_26_11_13_43_2009_896)--" Content-Transfer-Encoding: 7bit Cc: pgollucci@p6m7g8.com, itetcu@freebsd.org, pav@freebsd.org, freebsd-ports@freebsd.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2009 02:15:48 -0000 ----Security_Multipart(Tue_May_26_11_13_43_2009_896)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi David, Thanks kudos for tough works and discussions! David, is this the final patch which I should test? Best, From: David Naylor Subject: Re: MAKE_JOBS_UNSAFE (some more ports) Date: Mon, 25 May 2009 22:47:29 +0200 > On Monday 25 May 2009 20:01:25 Ion-Mihai Tetcu wrote: >> On Mon, 25 May 2009 10:03:12 +0200 >> >> David Naylor wrote: >> > On Sunday 24 May 2009 21:37:45 Ion-Mihai Tetcu wrote: >> > > On Sun, 24 May 2009 10:26:23 +0200 >> > > >> > > David Naylor wrote: >> > > > On Sunday 24 May 2009 00:16:37 Maho NAKATA wrote: >> > > > > Hi I tested it yesterday, >> > > > > >> > > > > 1. >> > > > > I need >> > > > > >> > > > > > MAKE_JOBS_SAFE= yes >> > > > > >> > > > > in the Makefile. >> > > > >> > > > Yes, you would need that. I believe that will be default. >> > > > >> > > > > 2. with above patch, ooo2 doesn't launch parallele jobs. >> > > > >> > > > I spotted that problem after submitting the patch, if you >> > > > explicitly set MAKE_JOBS_NUMBER to something it will work. >> > > > >> > > > The problem is that ooo2 does (in effect): >> > > > .if (${MAKE_JOBS_NUMBER} > 1) >> > > > # Stuff >> > > > .else >> > > > # Other stuff >> > > > .endif >> > > > and that doesn't work as expected with MAKE_JOBS_NUMBER=`sysctl >> > > > kern.smp.cpus` as the command is not resolved. >> > > >> > > w/o patch >> > > editors/openoffice.org-3 openoffice.org-3.1.0 4:53:27 >> > > >> > > with patch: >> > > + MAKE_JOBS_SAFE= yes >> > > + MAKE_JOBS_NUMBER= 4 >> > > + MAXPROCESSES?= ${MAKE_JOBS_NUMBER} >> > > + MAXMODULES?= ${MAKE_JOBS_NUMBER} >> > > >> > > editors/openoffice.org-3 openoffice.org-3.1.0 48:51 >> > > >> > > The build is done in >> > > /dev/md0 on /usr/local/tinderbox/7-STABLE-FPT-NPD (ufs, >> > > asynchronous, local, noatime) >> > >> > Wow, that is quite a speedup. Is it even possible (4 * 60 + 53)/4 = >> > 73, and you get 48 (that is 152% scaling efficiency). This would >> > mean a serious performance problem with the ooo3 build script and >> > MAX* =1. >> > >> > I'll make a patch tonight (+10 hours) that will fix ooo2 in the >> > default case. You can test ooo2 with patch and MAKE_JOBS_NUMBER >> > preset (not using default value) and MAKE_JOBS_SAFE=yes. >> >> BTW, what about using the same vars for parallel building in all OOo >> port? > > Done, the following patch uses MAKE_JOBS_NUMBER for all the variables in OOo. > > It also tries to be efficient when resolving the MAKE_JOBS_NUMBER to a value > (only done when a port sets USE_MAKE_JOBS, as in the OOo2-RC and OOo2 case). > > This should fix OOo2* builds and support such use cases for other ports... ----Security_Multipart(Tue_May_26_11_13_43_2009_896)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEABECAAYFAkobUFcACgkQpcQqaPiEzflKFACfaJoGe5r+wmrUTEoMjSsvY13j 8QIAoKcutfvgMKmLcTnPPbDIyGDSJqHq =jdZF -----END PGP SIGNATURE----- ----Security_Multipart(Tue_May_26_11_13_43_2009_896)----