From owner-freebsd-security Thu Apr 5 17:33:57 2001 Delivered-To: freebsd-security@freebsd.org Received: from Awfulhak.org (awfulhak.demon.co.uk [194.222.196.252]) by hub.freebsd.org (Postfix) with ESMTP id F3C3D37B422 for ; Thu, 5 Apr 2001 17:33:53 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.3/8.11.3) with ESMTP id f360XkU13167; Fri, 6 Apr 2001 01:33:46 +0100 (BST) (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.3/8.11.3) with ESMTP id f360XfP03505; Fri, 6 Apr 2001 01:33:41 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200104060033.f360XfP03505@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: "Andrey A. Chernov" Cc: Matt Dillon , Mark.Andrews@nominum.com, Chris Byrnes , security@FreeBSD.ORG, brian@Awfulhak.org Subject: Re: ntpd patch In-Reply-To: Message from "Andrey A. Chernov" of "Fri, 06 Apr 2001 03:54:59 +0400." <20010406035459.A6350@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 06 Apr 2001 01:33:41 +0100 From: Brian Somers Sender: owner-freebsd-security@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > On Thu, Apr 05, 2001 at 16:28:23 -0700, Matt Dillon wrote: > > Off-by-1 fix + > > buffer underflow http://apollo.backplane.com/FreeBSD/ntpd-patch2.diff > > > > For this one please change > > + while (tp != buf && isspace((int)(*(tp-1)))) > > to > > + while (tp != buf && isspace((unsigned char)(*(tp-1)))) > > (int) cast is completely wrong and dangerous. $ man isspace ..... SYNOPSIS #include int isspace(int c) ..... I believe the int is correct. > -- > Andrey A. Chernov > http://ache.pp.ru/ -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-security" in the body of the message