From owner-cvs-all@FreeBSD.ORG  Sat Mar  6 00:10:40 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3C03116A4CE; Sat,  6 Mar 2004 00:10:40 -0800 (PST)
Received: from mta7.pltn13.pbi.net (mta7.pltn13.pbi.net [64.164.98.8])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 88C5843D1D; Sat,  6 Mar 2004 00:10:39 -0800 (PST)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org
	(433ec49f2e42ece580700a7776869f78@adsl-67-119-53-203.dsl.lsan03.pacbell.net
	[67.119.53.203])i268Ac1l010892;	Sat, 6 Mar 2004 00:10:39 -0800 (PST)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 2271A5187D; Sat,  6 Mar 2004 00:10:38 -0800 (PST)
Date: Sat, 6 Mar 2004 00:10:38 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: Joe Marcus Clarke <marcus@FreeBSD.org>
Message-ID: <20040306081037.GA27564@xor.obsecurity.org>
References: <200403060733.i267XKd3044611@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc"
Content-Disposition: inline
In-Reply-To: <200403060733.i267XKd3044611@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www/mplayer-plugin Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Mar 2004 08:10:40 -0000


--C7zPtVaVf+AK4Oqc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 05, 2004 at 11:33:20PM -0800, Joe Marcus Clarke wrote:
> marcus      2004/03/05 23:33:20 PST
>=20
>   FreeBSD ports repository
>=20
>   Modified files:
>     www/mplayer-plugin   Makefile=20
>   Log:
>   Add firefox support via WITH_MOZILLA=3Dfirefox.  Note: this only works =
for
>   mplayer-plugin.  Setting WITH_MOZILLA=3Dfirefox will not work with the
>   galeon ports.

Shouldn't this be WITH_FIREFOX=3Dyes or similar?  Most WITH_ and
WITHOUT_ variables do not care about the value, and giving them
special values makes it difficult to use with configuration tools like
'make config'.

Kris

--C7zPtVaVf+AK4Oqc
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFASYd9Wry0BWjoQKURAqBNAJ47VciSAN6oNG7r2W3kFdHAHAq56wCfZ0G6
Vd/yJiCM1bkX+GXWnd903YM=
=fYJk
-----END PGP SIGNATURE-----

--C7zPtVaVf+AK4Oqc--