Date: Sat, 09 Dec 1995 23:11:39 -0800 From: Paul Traina <pst@shockwave.com> To: Peter Wemm <peter@jhome.DIALix.COM> Cc: Bruce Evans <bde@freefall.freebsd.org>, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/net if_tun.c Message-ID: <199512100711.XAA01990@precipice.shockwave.com> In-Reply-To: Your message of "Sun, 10 Dec 1995 13:37:10 %2B0800." <Pine.BSF.3.91.951210133345.6047C-100000@jhome.DIALix.COM>
next in thread | previous in thread | raw e-mail | index | archive | help
I would like to urge caution here. I'm rather alarmed by the number of changes that have gone into -current over the last few weeks which have made it much more difficult to bring in new revisions for software that we originally obtained elsewhere. Just to start, we can discuss pcvt and voxware. The only thing we really had as a standard kernel api was 4.4Lite-2, which while ugly, was common between *BSD[i]. While I won't dispute that the cleanup is, over-all, a good thing (and has found many bugs), I am pretty worried about the complete restructuring of a lot of the include files and the changes in assumptions about what is necessary. Please, just understand, we do obtain software from other sources and there's also a desire to be able to transfer our code back to other organizations. The further we diverge, the less we'll be able to do so. Paul From: Peter Wemm <peter@jhome.DIALix.COM> Subject: Re: cvs commit: src/sys/net if_tun.c On Sat, 9 Dec 1995, Bruce Evans wrote: > > bde 95/12/09 17:20:19 > > Modified: sys/net if_tun.c > Log: > Restored used variable `name[32]' (used by DEVFS). > > Removed an `#ifdef __FreeBSD__'. Hundreds, if not thousands of other > FreeBSD-specific things aren't ifdefed. I think our source could stand a lot more cleanup in this way.. After all, our sources are for FreeBSD, not GenericBSD or PortableBSD... Especially so, since we've not been consistant. I think the only real place where this kind of thing needs to stay is where we've taken 3rd party device drivers into our source that we dont maintain ourselves, and have cross-machine and version portability built in (if_cx and cx.c for example). -Peter
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199512100711.XAA01990>