Date: Tue, 3 Feb 2004 10:15:44 -0500 From: John Baldwin <jhb@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: current@freebsd.org Subject: Re: WITNESS broken in subr_witness.c 1.168 Message-ID: <200402031015.44438.jhb@FreeBSD.org> In-Reply-To: <20040204000759.F593@gamplex.bde.org> References: <20040204000759.F593@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 03 February 2004 08:10 am, Bruce Evans wrote: > % RCS file: /home/ncvs/src/sys/kern/subr_witness.c,v > % Working file: subr_witness.c > % head: 1.168 > % ... > % ---------------------------- > % revision 1.168 > % date: 2004/02/02 22:15:17; author: jhb; state: Exp; lines: +2 -1 > % - Assert that witness_cold is not true in enroll(). > % - Only check witness_watch once in enroll(). > % > % Reported by: ru (2) > % ---------------------------- > > This is equivalent to asserting that 1 is not true in enroll(), since > enroll() is always called from witness_initialize() before the latter > has set witness_cold to 0. Oof. > The quick fix is to remove the assertion. Agreed. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200402031015.44438.jhb>