From owner-freebsd-current@FreeBSD.ORG  Tue Feb  3 07:22:56 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1343E16A4CE
	for <current@freebsd.org>; Tue,  3 Feb 2004 07:22:56 -0800 (PST)
Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DE23F43D55
	for <current@freebsd.org>; Tue,  3 Feb 2004 07:22:54 -0800 (PST)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 8118 invoked from network); 3 Feb 2004 15:22:54 -0000
Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx)
	([216.27.160.63])          (envelope-sender <jhb@FreeBSD.org>)
	encrypted SMTP
	for <current@freebsd.org>; 3 Feb 2004 15:22:54 -0000
Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i13FMdM6000428;
	Tue, 3 Feb 2004 10:22:49 -0500 (EST)
	(envelope-from jhb@FreeBSD.org)
From: John Baldwin <jhb@FreeBSD.org>
To: Bruce Evans <bde@zeta.org.au>
Date: Tue, 3 Feb 2004 10:15:44 -0500
User-Agent: KMail/1.5.4
References: <20040204000759.F593@gamplex.bde.org>
In-Reply-To: <20040204000759.F593@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200402031015.44438.jhb@FreeBSD.org>
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)
cc: current@freebsd.org
Subject: Re: WITNESS broken in subr_witness.c 1.168
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2004 15:22:56 -0000

On Tuesday 03 February 2004 08:10 am, Bruce Evans wrote:
> % RCS file: /home/ncvs/src/sys/kern/subr_witness.c,v
> % Working file: subr_witness.c
> % head: 1.168
> % ...
> % ----------------------------
> % revision 1.168
> % date: 2004/02/02 22:15:17;  author: jhb;  state: Exp;  lines: +2 -1
> % - Assert that witness_cold is not true in enroll().
> % - Only check witness_watch once in enroll().
> %
> % Reported by:	ru (2)
> % ----------------------------
>
> This is equivalent to asserting that 1 is not true in enroll(), since
> enroll() is always called from witness_initialize() before the latter
> has set witness_cold to 0.

Oof.

> The quick fix is to remove the assertion.

Agreed.

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org