From owner-svn-src-all@FreeBSD.ORG  Sat Nov  8 20:11:09 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id DD6C18F8;
 Sat,  8 Nov 2014 20:11:09 +0000 (UTC)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id A65047A5;
 Sat,  8 Nov 2014 20:11:08 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id WAA18767;
 Sat, 08 Nov 2014 22:12:54 +0200 (EET) (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1XnCLc-000FBw-5Y; Sat, 08 Nov 2014 22:11:00 +0200
Message-ID: <545E7882.90209@FreeBSD.org>
Date: Sat, 08 Nov 2014 22:09:38 +0200
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Alexander Kabaev <kabaev@gmail.com>, Mark Johnston <markj@FreeBSD.org>
Subject: Re: svn commit: r274200 - head/share/mk
References: <201411062246.sA6MkeLN018716@svn.freebsd.org>
 <20141108120000.3f16feab@kan>
In-Reply-To: <20141108120000.3f16feab@kan>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Nov 2014 20:11:10 -0000

On 08/11/2014 19:00, Alexander Kabaev wrote:
> On Thu, 6 Nov 2014 22:46:40 +0000 (UTC) Mark Johnston <markj@FreeBSD.org>
> wrote:
> 
>> Author: markj Date: Thu Nov  6 22:46:40 2014 New Revision: 274200 URL:
>> https://svnweb.freebsd.org/changeset/base/274200
>> 
>> Log: Automatically build with debug symbols when building with WITH_CTF. 
>> Otherwise there's nothing for ctfconvert to do, and it ends up emitting
>> an error for each object file. Also remove some redundant checks from
>> bsd.prog.mk and bsd.lib.mk.
> <SKIP>
>> 
>> -.if ${MK_CTF} != "no" && ${DEBUG_FLAGS:M-g} != "" +.if ${MK_CTF} !=
>> "no" CTFFLAGS+= -g .endif .else
> 
> I have a question about this and another similar change. Does it have the
> effect of always leaving binaries with debug symbols in id WITH_CTF is in
> effect and do we now rely solely on install stripping binaries at later
> stage to get rid of the debug symbols? IMHO, we should only pass -g to
> ctfconvert if WITH_CTF is set _and_ user requested debug symbols
> explicitly. Your change seems to be breaking that.

Hmm, I do not follow your logic here, sorry.
So, you say that stripping should be ctfconvert's job? Why?

-- 
Andriy Gapon