From owner-svn-ports-all@FreeBSD.ORG Fri Feb 6 23:37:43 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4B418510 for ; Fri, 6 Feb 2015 23:37:43 +0000 (UTC) Received: from vfemail.net (nine.vfemail.net [108.76.175.9]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DCD09F9C for ; Fri, 6 Feb 2015 23:37:42 +0000 (UTC) Received: (qmail 27148 invoked by uid 89); 6 Feb 2015 23:37:35 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 6 Feb 2015 23:37:34 -0000 Received: (qmail 27115 invoked by uid 89); 6 Feb 2015 23:37:17 -0000 Received: by simscan 1.3.1 ppid: 27101, pid: 27110, t: 0.0184s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 6 Feb 2015 23:37:17 -0000 Received: (qmail 23651 invoked by uid 89); 6 Feb 2015 23:37:17 -0000 Received: by simscan 1.4.0 ppid: 23625, pid: 23647, t: 1.0030s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by 172.16.100.62 with ESMTPA; 6 Feb 2015 23:37:16 -0000 From: Jan Beich To: Rene Ladan Subject: Re: svn commit: r378563 - in head/www/chromium: . files References: <201502062228.t16MSqq8072725@svn.freebsd.org> Date: Sat, 07 Feb 2015 00:37:04 +0100 In-Reply-To: <201502062228.t16MSqq8072725@svn.freebsd.org> (Rene Ladan's message of "Fri, 6 Feb 2015 22:28:52 +0000 (UTC)") Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, John Marino , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2015 23:37:43 -0000 --=-=-= Content-Type: text/plain Rene Ladan writes: > +#elif V8_OS_FREEBSD > ++# ifdef __DragonFly__ > ++ return static_cast(lwp_gettid()); Ironically, V8_OS_DRAGONFLYBSD is ignored with USES=alias. Try the following to make upstreaming easier #elif V8_OS_DRAGONFLYBSD || defined(__DragonFly__) return static_cast(lwp_gettid()); #elif V8_OS_FREEBSD ... > ++# elif __FreeBSD_version__ < 900031 Have you made sure __FreeBSD_version__ is defined? > ++ return 0; /* ! */ Maybe replace with #include ... long lwpid; thr_self(&lwpid); return static_cast(lwpid); > ++# else Bonus for upstream #if defined(OS_NETBSD) #include #endif ... #elif V8_OS_NETBSD return static_cast(_lwp_self()); #else > + return static_cast(pthread_getthreadid_np()); > ++# endif > #else > return static_cast(pthread_self()); > #endif --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJU1VAgXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bZTUH/Rf4AcorWCVE0tQ3Pu1qs8qD YTxr5MPuMM72RYQhc/Ls4D9M4jZOux6yDGW0UmsoM4qpazYUseDrkKupO39baRaG f9p+NvHqZna3MWpzAGKRsoBZIz2RZFC+NMC9+LAkYhHsXUrxHh1Dpj0EGz7rHhfW b6pxdgV3P4KgImv1Eu4xhyBz/0t59lgqMBnUK9/hoyJki7LB2NrcpSPAXShPMVww b1mZaBInpOYy8C2CJIpNTplCPOVZZ+NIcjBTV6zIu2N7rVp1FLvfKSzh/lEuViIh Y0BRsTWeJvcgXHeuBXlfEUzC3qeyRxp4UOdiuY4DYPpcn3u8i3GDUs3dWc1txrg= =iLcu -----END PGP SIGNATURE----- --=-=-=--