From owner-svn-ports-all@FreeBSD.ORG  Sun Apr 12 17:20:44 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4543EDF7;
 Sun, 12 Apr 2015 17:20:44 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 18D4BCEE;
 Sun, 12 Apr 2015 17:20:43 +0000 (UTC)
Received: from [192.168.1.22] (159.Red-79-148-64.dynamicIP.rima-tde.net
 [79.148.64.159])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id DC54943BC7;
 Sun, 12 Apr 2015 12:20:39 -0500 (CDT)
Message-ID: <552AA964.4000306@marino.st>
Date: Sun, 12 Apr 2015 19:20:36 +0200
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Jan Beich <jbeich@FreeBSD.org>, John Marino <marino@FreeBSD.org>
Subject: Re: svn commit: r383843 - head/games/megaglest
References: <201504120832.t3C8W2oh056956@svn.freebsd.org>
 <7fth-sdr1-wny@FreeBSD.org>
In-Reply-To: <7fth-sdr1-wny@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Apr 2015 17:20:44 -0000

On 4/12/2015 15:00, Jan Beich wrote:
> John Marino <marino@FreeBSD.org> writes:
> 
>>   Megaglest cannot be built under c++11 standard from the latest clang.
>>   It catches a narrowing error.  The real solution is to fix the c++
>>   code (it wasn't the only problem, but the first to trigger an error over
>>   a warning).  The c++11 standard is required for wx, so it can't be
>>   unspecified.  It turns out that gcc48 will not catch the error that clang
>>   does so the temporary fix is to require gcc48 for all FreeBSD releases.
>>   This may work for gcc49 as well, but it's likely that gcc5 will also
>>   catch the bug and break.
> 
> CXXFLAGS += -Wno-c++11-narrowing ? GCC ignores unknown -Wno-foo.
> 
> Or maybe poke upstream if it has a fix:
> 
> #v+
> Clang fix for tdefl_write_image_to_png_file_in_memory() from toffaletti
> 
> --- source/shared_lib/sources/miniz/miniz.c	(revision 56)
> +++ source/shared_lib/sources/miniz/miniz.c	(revision 57)


IIUC - you're saying 1) what I did builds but doesn't work and 2) you've
got a patch that will let it build on clang.

If I got that right, just go ahead and commit it.  Are you flying solo
or with implicit permission these days?

Thanks!

John