From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jan 31 22:20:02 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A746410656E8 for ; Sat, 31 Jan 2009 22:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 68BBD8FC0A for ; Sat, 31 Jan 2009 22:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n0VMK2Ov064683 for ; Sat, 31 Jan 2009 22:20:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n0VMK2iF064682; Sat, 31 Jan 2009 22:20:02 GMT (envelope-from gnats) Resent-Date: Sat, 31 Jan 2009 22:20:02 GMT Resent-Message-Id: <200901312220.n0VMK2iF064682@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Gerald Pfeifer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4855F10657C4; Sat, 31 Jan 2009 22:15:05 +0000 (UTC) (envelope-from pfeifer@sputnik1.dbai.tuwien.ac.at) Received: from sputnik1.dbai.tuwien.ac.at (sputnik1.dbai.tuwien.ac.at [128.131.111.141]) by mx1.freebsd.org (Postfix) with ESMTP id D34EB8FC14; Sat, 31 Jan 2009 22:15:04 +0000 (UTC) (envelope-from pfeifer@sputnik1.dbai.tuwien.ac.at) Received: from sputnik1.dbai.tuwien.ac.at (localhost [127.0.0.1]) by sputnik1.dbai.tuwien.ac.at (8.14.3/8.14.3) with ESMTP id n0VMEwil076141; Sat, 31 Jan 2009 23:14:58 +0100 (CET) (envelope-from pfeifer@sputnik1.dbai.tuwien.ac.at) Received: (from pfeifer@localhost) by sputnik1.dbai.tuwien.ac.at (8.14.3/8.14.3/Submit) id n0VMEwF2076140; Sat, 31 Jan 2009 23:14:58 +0100 (CET) (envelope-from pfeifer) Message-Id: <200901312214.n0VMEwF2076140@sputnik1.dbai.tuwien.ac.at> Date: Sat, 31 Jan 2009 23:14:58 +0100 (CET) From: Gerald Pfeifer To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/131228: portlint: avoid false positive regarding /boot/loader.conf X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Jan 2009 22:20:03 -0000 >Number: 131228 >Category: ports >Synopsis: portlint: avoid false positive regarding /boot/loader.conf >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Jan 31 22:20:02 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Gerald Pfeifer >Release: FreeBSD 7.1-RELEASE i386 >Organization: >Environment: >Description: Current versions of portlint issue the following warning for lang/gcc43 and similar ports: WARN: Makefile: possible use of absolute pathname "/boot/loader.conf)". This is correct in that this is indeed an absolute pathname, alas it is a false positive in the sense that the use of this here is fair: this really is an absolute name that needs to be specified like this. >How-To-Repeat: cd $PORTSDIR/lang/gcc43 ; portlint -C >Fix: Proposed patch, tested on my side, and making it easier to add any further exceptions if needed. --- /usr/local/bin/portlint 2009-01-31 12:51:17.000000000 +0100 +++ portlint 2009-01-31 23:10:22.942160000 +0100 @@ -2994,7 +2994,9 @@ $i = ''; } } - if ($i ne '') { + # Ignore some (otherwise) false positives. + if ($i ne '' + && $i !~ '/boot/loader.conf' ) { $i =~ s/\s.*$//; $i =~ s/['"].*$//; #' $i = substr($i, 0, 20) . '...' if (20 < length($i)); >Release-Note: >Audit-Trail: >Unformatted: