Date: Fri, 26 Mar 2021 08:28:51 -0300 From: "Danilo G. Baio" <dbaio@FreeBSD.org> To: Gleb Popov <arrowd@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org> Subject: Re: svn commit: r569233 - head/lang/ghc Message-ID: <20210326112851.pivtavly5kbvsvqr@t480.local> In-Reply-To: <CALH631m1HzFBdZfLs1EAe7WDRo5h_roE-_D3dVes28KufN7GAA@mail.gmail.com> References: <202103260044.12Q0idbc009254@repo.freebsd.org> <CALH631m1HzFBdZfLs1EAe7WDRo5h_roE-_D3dVes28KufN7GAA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--63cxukkc2him3g63 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 26, 2021 at 11:06:32AM +0300, Gleb Popov wrote: > On Fri, Mar 26, 2021 at 3:44 AM Danilo G. Baio <dbaio@freebsd.org> wrote: >=20 > > Author: dbaio > > Date: Fri Mar 26 00:44:39 2021 > > New Revision: 569233 > > URL: https://svnweb.freebsd.org/changeset/ports/569233 > > > > Log: > > lang/ghc: Generate PORTDOCS pkg-plist dynamically > > > > This is the best approach for ports building its documentation with > > Sphinx in > > html and will save time on future Sphinx updates. > > > > Approved by: portmgr blanket > > > > Modified: > > head/lang/ghc/Makefile > > head/lang/ghc/pkg-plist > > > > Modified: head/lang/ghc/Makefile > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/lang/ghc/Makefile Fri Mar 26 00:40:44 2021 (r56923= 2) > > +++ head/lang/ghc/Makefile Fri Mar 26 00:44:39 2021 (r56923= 3) > > @@ -84,6 +84,8 @@ BOOT_LLVM_VERSION=3D 90 > > > > PLIST_SUB=3D GHC_VERSION=3D${GHC_VERSION} > > CABAL_VERSION=3D${CABAL_VERSION} > > > > +PORTDOCS=3D * > > + > > .include <bsd.port.pre.mk> > > > > # This version of ncurses is needed by bootstrap compiler > > >=20 > I spent quite a time to make the pkg-plist fully static, and now you make > such a change without consulting the port's maintainer. >=20 > I was thinking that static pkg-plist's are generally favored over > dynamically-generated ones. Why usual "make makeplist" didn't work for yo= u? > Why didn't you ask me to help you with Sphinx upgrade? Note that this is not a plist recommendation in general, just for documentation html and Sphinx. I've been doing this kind of changes since I started maintaining Sphinx and it's becoming easier to maintain/update Sphinx and all ports that use it over time. In this case there was an issue reported on Twitter, lang/ghc wasn't building with the older Sphinx, I think this kind of issue isn't nice because the port clearly works with both versions (yes I could set a Sphinx version >=3D 3.5.2), but this is a ports/plist/sphinx issue. The improvement here was tested on my set of poudriere jails with all options enabled, all options disabled, mixed values on Sphinx 3.5.2 and 3.4.3, I consider this an improvement for lang/ghc, which was made in others important ports as well. In the future, I'll surely ask for your help, thank you. Regards. --=20 Danilo G. Baio (dbaio) --63cxukkc2him3g63 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEORj0UTsjzCy+enIkmpN7LfMuiNcFAmBdxW9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDM5 MThGNDUxM0IyM0NDMkNCRTdBNzIyNDlBOTM3QjJERjMyRTg4RDcACgkQmpN7LfMu iNc1txAAskeeohV8LOBvJ19gDaCIsZvwD/e5LmsqPKt/nLGPMFNc4h/WgmMPsHps hZNXwp+yOoxpp7cPZ+K3vZz+7viM4Iw5FLogsvryXHGb49gteFN0yYa42dmX4G49 WB2rH6BOrFNbgNQLEdVaqfRoGzNpMjdGzSn81fK8+qWhVoNY7Ows/8a0GL/j35zA eI0Knm+RIptVsLPGIn9Kgo67ujAOXUz+3XaLrV4qCSQtYQo3I3tmUSGGQf5FGe8Q RZvPAndLdH4fZ0e+2K6QGWvjmNN2IcrPYLuyogNltsV/gcHDiHKaUWy9M1HD+Usw SeamY8EPjqb+t5gXCNNI4rSQ8a1DcWJmaC7LL0V1UxGBcAmMZUjDK+69HSJfOwwM s403Zn7N5QTcGZSVWHyJujQU6ygO4D+J5Ivg196tNBvAUorDStMOuH1l5GgKtNNR ox10uHfYazSvkTT75IgXK732qZe+DSb8g542JEyblYbYvCvJWbWUU7UCG/2RYrNB TkWYm5k8l0pzZE2Niu0RPhqqYUjEzcrqV8b4aoM95KVYwUpuav98xWFs5lvaNPtL sM2Lfwm2Zoq2DnqE9B7iqEcD3T+UGSaCThM0VXqm+u9sOuh+xSiR/xrGtplsK1Fh PfXcgyMsne9AQv4pEty56AE6t6vLvhZe3RQSugOPJ/xVpD5+65k= =CKab -----END PGP SIGNATURE----- --63cxukkc2him3g63--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210326112851.pivtavly5kbvsvqr>