From owner-svn-src-stable-12@freebsd.org Sat Jun 27 20:03:45 2020 Return-Path: Delivered-To: svn-src-stable-12@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E8F1D35B44C; Sat, 27 Jun 2020 20:03:45 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yb1-f195.google.com (mail-yb1-f195.google.com [209.85.219.195]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49vPp93H78z4PN1; Sat, 27 Jun 2020 20:03:45 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yb1-f195.google.com with SMTP id m16so6263697ybf.4; Sat, 27 Jun 2020 13:03:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a99ntSWDP6nr04eI791KIORs6dbVnQQV0dj2oCtowGE=; b=eHTRCp2FeVziZPlmjAMdMUFGHOdywNI6/mIJJTYEpTFt4SXTAM8XqaZyVf3PJ+WuJS tSFzbZZrbMOegwK1bBeDg55XU00rJAJZNrlWVpxsRAiMGG7IHI9B4feX7sxkcf/FnhM/ T/h+/7XNQX1vxf4RFkoapWIRhKNIYOvgTFy8+t5m90aiqQNxiWVaUS3N8hCmwcQBEvRy 8Zissm4ZDjouLbNUDGqX6S43+GrwhGTaCVKLWGRrZhfwj4tYAZKxMApltkelJ4lueBv5 f14HBLvpbSmQLugVEAlM6GLz9d+Zhp7/f09x+PglnieaqbOkqT18ksX7de5T+OzAN1vs AVJA== X-Gm-Message-State: AOAM530BpJ4JBiD+i2hP/tKl95Uyy+Wq6/WHZ8Lrh5PVITsZB3COTJZx jun7KCXMYROfu1ou5FA4pTm/JnoERGDlkDA7ihGXIWGs X-Google-Smtp-Source: ABdhPJwxfu47ICo1rSsg9vfm1sf3vMo4/8yq/b8vrbPgQlcuQkKhQIA7luSF6Q1pufo1R30NuW9XvVret5koG6PkZ0w= X-Received: by 2002:a25:69d1:: with SMTP id e200mr14827673ybc.127.1593288223806; Sat, 27 Jun 2020 13:03:43 -0700 (PDT) MIME-Version: 1.0 References: <202006271427.05RERbw3073838@repo.freebsd.org> In-Reply-To: <202006271427.05RERbw3073838@repo.freebsd.org> From: Li-Wen Hsu Date: Sun, 28 Jun 2020 04:03:32 +0800 Message-ID: Subject: Re: svn commit: r362687 - in stable/12/usr.bin/sed: . tests To: Mateusz Piotrowski <0mp@freebsd.org> Cc: src-committers , svn-src-all , svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 49vPp93H78z4PN1 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-stable-12@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for only the 12-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jun 2020 20:03:46 -0000 On Sat, Jun 27, 2020 at 10:27 PM Mateusz Piotrowski <0mp@freebsd.org> wrote: > > Author: 0mp (doc,ports committer) > Date: Sat Jun 27 14:27:37 2020 > New Revision: 362687 > URL: https://svnweb.freebsd.org/changeset/base/362687 > > Log: > MFC 362017, 362039, 362071: > > Read commands from stdin when -f - is passed to sed(1) > > This patch teaches sed to interpret a "-" in a special way when given > as an argument to the -f flag. > > This behavior is also present in GNU sed. > > PR: 244872 > Tested by: antoine (exp-run) > Reviewed by: pfg, tobik (older version) > Approved by: pfg (src) > Relnotes: yes > Differential Revision: https://reviews.freebsd.org/D24079 > > Remove duplicate lines from sed tests > > Reported by: yuripv > Approved by: pfg (src) > > Remove some more duplicate test cases I accidentally committed > > Reported by: markj, yuripv Hi, I think this MFC and for 11's might have some issues. The test cases under usr.bin.sed.sed2_test cannot be listed thus cannot be executed: https://ci.freebsd.org/job/FreeBSD-stable-12-i386-test/2458/testReport/junit/usr.bin.sed/sed2_test/ https://ci.freebsd.org/job/FreeBSD-stable-11-amd64-test/5150/testReport/junit/usr.bin.sed/sed2_test/ This is how they should look like: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/15686/testReport/usr.bin.sed/sed2_test/ You can try with `cd /usr/tests/usr.bin/sed && kyua list sed2_test`. Please check if the merged sed2_test.sh needs adjusting. Thanks, Li-Wen