From nobody Fri Jan 16 09:44:45 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dsw1V0rHwz6P2h5 for ; Fri, 16 Jan 2026 09:44:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dsw1T5r6Cz3fjy for ; Fri, 16 Jan 2026 09:44:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768556685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D8tN8niQAM7/xYPSnkyGTeX2QU3V3vpNxuK0IuygpPY=; b=oXBRn81hlniv9LeJ57ZWpnI/+P7c2oJiC0W8b+q1H/6MA1ZYn+Rf75uv1WcQBCYT1VBmdP 568PC7nzuTuPo4dnyfytDZcQy0+r+GWLXDc91+KRQzbklDa9IUJdkHflQXbb0qNv2uDXw/ CK+MqRYf324eeqWwHEUhEhl1su3xgi3wkvYR8G8yoR7zF7VwqpXgS5Mo3E4Wh+C/At80r8 WSt3yoRU9E2hYHqy9Z/tzUMz+Fd/+p/6ovAeseA+o5s4ORPscd9U83vPsf+/s7UzZTecPO 6WUllDrblVV8EJSsfznIzlCHl9dSh7jGqIlbjEV2AkqNIJDyIQiHId/bF9mn3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768556685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D8tN8niQAM7/xYPSnkyGTeX2QU3V3vpNxuK0IuygpPY=; b=ZxRWx2sS1suJSY+qCf5wV26VklLpF0GZWweCECNNLkP/kVplibwGxcEHZX/T5BcmUZdu/S a/e8LwjeKI7bVE9WcrkPjkHyZfmbmaocg3Bfq/2RW+QE24h/IjwvqRQDQA4VInOlBeXfrc tNTSNtUXu7evZrNs/JWNg8aqrbYLms9VUIUA5zznl/8/MtZ/LQ5DCnlm72qzNTUfEZvOew xsPef34Z68r6UnqU209TpgC4YDXWfcBddlj1yQmj26DNX6muHIaZ5s8oZdJkVDP9XjMuF3 vNVNqpKEf/dySI36369ZQmacVF4EAlrwpSTfCe90/JvXjnHh3k8Ck3Bt3ut/8Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768556685; a=rsa-sha256; cv=none; b=hH3v68D4fYiEYm2Vv8dMoEeNxnMSRXotwHUAFD5yzrGh3ZgzTBHSZXhpRyTykLFifexcEk 4PnHxIQC4/clifUFuWOaf0rXYigXMsL7VUJxAex4yHm/noBH8CgPCT+f7xmPSG2B6d5Bkj a8tp32kxLGhYgA29dxQhLggHfvXiZ7x0mDVQAzCEfz5N1uwOyW/KKBoyqsqeS7mwgPfI46 +V8FvPQTXqfmKfBobOFm9ubnSIAzm+cN4f58983bdCCSuxbqgbaiqcxHsrQsIsSacwN5w/ KB+2GMMQafnFBJ9IwYa31wGtQOhvWVJZifdNlF9NbTocb4JK3EIRdzTLW+AIXQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dsw1T5NNxz182t for ; Fri, 16 Jan 2026 09:44:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 23980 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 16 Jan 2026 09:44:45 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Brooks Davis Subject: git: 373c72ad5044 - main - virtual_oss: build system tidying List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: brooks X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 373c72ad5044d5f84b7f3fa169d37e7214729f74 Auto-Submitted: auto-generated Date: Fri, 16 Jan 2026 09:44:45 +0000 Message-Id: <696a088d.23980.24aae0c8@gitrepo.freebsd.org> The branch main has been updated by brooks: URL: https://cgit.FreeBSD.org/src/commit/?id=373c72ad5044d5f84b7f3fa169d37e7214729f74 commit 373c72ad5044d5f84b7f3fa169d37e7214729f74 Author: Brooks Davis AuthorDate: 2026-01-16 09:33:56 +0000 Commit: Brooks Davis CommitDate: 2026-01-16 09:33:56 +0000 virtual_oss: build system tidying general: - find libsamplerate's headers in the temporary sysroot instead of digging in the source tree. - use LIBADD where possible lib/virtual_oss: - centralize SHLIBDIR define - centralize include path for internal headers - don't try to find libsamplerate directly in .OBJDIR No functional changes. Reviewed by: christos Sponsored by: DARPA, AFRL Differential Revision: https://reviews.freebsd.org/D54704 --- lib/virtual_oss/Makefile | 2 -- lib/virtual_oss/Makefile.inc | 6 ++++-- lib/virtual_oss/bt/Makefile | 7 ++----- lib/virtual_oss/null/Makefile | 4 +--- lib/virtual_oss/oss/Makefile | 4 +--- lib/virtual_oss/sndio/Makefile | 4 +--- usr.sbin/virtual_oss/virtual_bt_speaker/Makefile | 2 +- usr.sbin/virtual_oss/virtual_oss/Makefile | 9 ++++----- 8 files changed, 14 insertions(+), 24 deletions(-) diff --git a/lib/virtual_oss/Makefile b/lib/virtual_oss/Makefile index 11715bbcbf0b..e6cb5fbe5985 100644 --- a/lib/virtual_oss/Makefile +++ b/lib/virtual_oss/Makefile @@ -1,7 +1,5 @@ .include -SHLIBDIR?= ${LIBDIR}/virtual_oss - SUBDIR+= null \ oss diff --git a/lib/virtual_oss/Makefile.inc b/lib/virtual_oss/Makefile.inc index 877465a5c548..2a0c75218f49 100644 --- a/lib/virtual_oss/Makefile.inc +++ b/lib/virtual_oss/Makefile.inc @@ -1,5 +1,7 @@ PACKAGE= sound -.include "../Makefile.inc" +SHLIBDIR= ${LIBDIR}/virtual_oss + +CFLAGS+= -I${SRCTOP}/usr.sbin/virtual_oss/virtual_oss -LDFLAGS+= -L${.OBJDIR:H:H}/libsamplerate +.include "../Makefile.inc" diff --git a/lib/virtual_oss/bt/Makefile b/lib/virtual_oss/bt/Makefile index 15413b7a1f1e..9a4ce586ef95 100644 --- a/lib/virtual_oss/bt/Makefile +++ b/lib/virtual_oss/bt/Makefile @@ -1,14 +1,11 @@ SHLIB_NAME= voss_bt.so -SHLIBDIR= ${LIBDIR}/virtual_oss SRCS= bt.c \ avdtp.c \ sbc_encode.c -CFLAGS+= -I${SRCTOP}/usr.sbin/virtual_oss/virtual_oss \ - -I${SRCTOP}/contrib/libsamplerate -LDFLAGS+= -lbluetooth -lsdp -LIBADD= samplerate +CFLAGS+= -I${SYSROOT:U${DESTDIR}}/${INCLUDEDIR}/private/samplerate +LIBADD= bluetooth samplerate sdp .if defined(HAVE_LIBAV) CFLAGS+= -I${LOCALBASE:U/usr/local}/include -DHAVE_LIBAV diff --git a/lib/virtual_oss/null/Makefile b/lib/virtual_oss/null/Makefile index ec5c2d40f665..5c265d1be055 100644 --- a/lib/virtual_oss/null/Makefile +++ b/lib/virtual_oss/null/Makefile @@ -1,10 +1,8 @@ SHLIB_NAME= voss_null.so -SHLIBDIR= ${LIBDIR}/virtual_oss SRCS= null.c -CFLAGS+= -I${SRCTOP}/usr.sbin/virtual_oss/virtual_oss \ - -I${SRCTOP}/contrib/libsamplerate +CFLAGS+= -I${SYSROOT:U${DESTDIR}}/${INCLUDEDIR}/private/samplerate LIBADD= samplerate .include diff --git a/lib/virtual_oss/oss/Makefile b/lib/virtual_oss/oss/Makefile index 257d7f0c0bae..773b3518602e 100644 --- a/lib/virtual_oss/oss/Makefile +++ b/lib/virtual_oss/oss/Makefile @@ -1,10 +1,8 @@ SHLIB_NAME= voss_oss.so -SHLIBDIR= ${LIBDIR}/virtual_oss SRCS= oss.c -CFLAGS+= -I${SRCTOP}/usr.sbin/virtual_oss/virtual_oss \ - -I${SRCTOP}/contrib/libsamplerate +CFLAGS+= -I${SYSROOT:U${DESTDIR}}/${INCLUDEDIR}/private/samplerate LIBADD= samplerate .include diff --git a/lib/virtual_oss/sndio/Makefile b/lib/virtual_oss/sndio/Makefile index 9b5af63a3246..238507be1e4b 100644 --- a/lib/virtual_oss/sndio/Makefile +++ b/lib/virtual_oss/sndio/Makefile @@ -1,10 +1,8 @@ SHLIB_NAME= voss_sndio.so -SHLIBDIR= ${LIBDIR}/virtual_oss SRCS= sndio.c -CFLAGS+= -I${SRCTOP}/usr.sbin/virtual_oss/virtual_oss \ - -I${SRCTOP}/contrib/libsamplerate \ +CFLAGS+= -I${SYSROOT:U${DESTDIR}}/${INCLUDEDIR}/private/samplerate \ -I${LOCALBASE:U/usr/local}/include LDFLAGS+= -L${LOCALBASE:U/usr/local}/lib -lsndio LIBADD= samplerate diff --git a/usr.sbin/virtual_oss/virtual_bt_speaker/Makefile b/usr.sbin/virtual_oss/virtual_bt_speaker/Makefile index 0f5fb2b4eb99..d3bb0e4cdb44 100644 --- a/usr.sbin/virtual_oss/virtual_bt_speaker/Makefile +++ b/usr.sbin/virtual_oss/virtual_bt_speaker/Makefile @@ -6,6 +6,6 @@ SRCS= bt_speaker.c CFLAGS+= -I${SRCTOP}/usr.sbin/virtual_oss/virtual_oss \ -I${SRCTOP}/lib/virtual_oss/bt -LDFLAGS+= -lm -lbluetooth -lsdp +LIBADD= bluetooth m sdp .include diff --git a/usr.sbin/virtual_oss/virtual_oss/Makefile b/usr.sbin/virtual_oss/virtual_oss/Makefile index cdb6bcac3fad..78532356f097 100644 --- a/usr.sbin/virtual_oss/virtual_oss/Makefile +++ b/usr.sbin/virtual_oss/virtual_oss/Makefile @@ -12,13 +12,12 @@ SRCS= audio_delay.c \ ring.c \ virtual_oss.c -CFLAGS+= -I${SRCTOP}/contrib/libsamplerate +CFLAGS+= -I${SYSROOT:U${DESTDIR}}/${INCLUDEDIR}/private/samplerate + +LIBADD= cuse m nv pthread samplerate # The --export-dynamic-symbol flags below are needed because some backends make # use of those symbols. -LDFLAGS+= -lpthread -lcuse -lnv -lm \ - -Wl,--export-dynamic-symbol=virtual_oss_wait \ +LDFLAGS+= -Wl,--export-dynamic-symbol=virtual_oss_wait \ -Wl,--export-dynamic-symbol=voss_has_synchronization -LIBADD= samplerate -LDFLAGS+= -L${.OBJDIR:H:H}/libsamplerate .include