From owner-svn-src-stable@FreeBSD.ORG  Sun Nov 21 14:39:11 2010
Return-Path: <owner-svn-src-stable@FreeBSD.ORG>
Delivered-To: svn-src-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E117A106566B;
	Sun, 21 Nov 2010 14:39:11 +0000 (UTC)
	(envelope-from gavin@ury.york.ac.uk)
Received: from gse-mta-27.emailfiltering.com (gse-mta-27-tx.emailfiltering.com
	[194.116.198.158])
	by mx1.freebsd.org (Postfix) with ESMTP id D988C8FC0A;
	Sun, 21 Nov 2010 14:39:10 +0000 (UTC)
Received: from mail-gw5.york.ac.uk ([144.32.129.29])
	by gse-mta-27.emailfiltering.com with emfmta (version 4.6.0.72) by TLS
	id 817385016
	for jilles@stack.nl;ee1ae18fa91dc1f8; Sun, 21 Nov 2010 14:39:09 +0000
Received: from ury.york.ac.uk ([144.32.108.81]:48029)
	by mail-gw5.york.ac.uk with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <gavin@ury.york.ac.uk>)
	id 1PKB4O-0002XR-9Y; Sun, 21 Nov 2010 14:39:08 +0000
Received: from gavin (helo=localhost)
	by ury.york.ac.uk with local-esmtp (Exim 4.72)
	(envelope-from <gavin@ury.york.ac.uk>)
	id 1PKB4O-000370-2O; Sun, 21 Nov 2010 14:39:08 +0000
Date: Sun, 21 Nov 2010 14:39:08 +0000 (GMT)
From: Gavin Atkinson <gavin@FreeBSD.org>
X-X-Sender: gavin@ury.york.ac.uk
To: Jilles Tjoelker <jilles@stack.nl>
In-Reply-To: <20101121133531.GB17293@stack.nl>
Message-ID: <alpine.LNX.2.00.1011211437200.10869@ury.york.ac.uk>
References: <201011201646.oAKGkGW7019085@svn.freebsd.org>
	<alpine.LNX.2.00.1011211241060.2142@ury.york.ac.uk>
	<20101121133531.GB17293@stack.nl>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: <gavin@ury.york.ac.uk>
Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, svn-src-stable-8@freebsd.org
Subject: Re: svn commit: r215572 - stable/8/sys/sys
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
	<svn-src-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable>, 
	<mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
	<mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Nov 2010 14:39:12 -0000

On Sun, 21 Nov 2010, Jilles Tjoelker wrote:
> On Sun, Nov 21, 2010 at 12:42:24PM +0000, Gavin Atkinson wrote:
> > On Sat, 20 Nov 2010, Jilles Tjoelker wrote:
> > > Author: jilles
> > > Date: Sat Nov 20 16:46:16 2010
> > > New Revision: 215572
> > > URL: http://svn.freebsd.org/changeset/base/215572
> 
> > > Log:
> > >   MFC r215183: Make POLL_ERR and POLL_HUP different.
> 
> > >   The kernel currently does not generate any of the POLL_* constants, but
> > >   some applications use them and break if they are not all distinct.
> 
> > Is this a good idea to merge to a stable branch?  Presumably some of those 
> > same applications will now break due to the constants changing?
> 
> The typical usage appears to be
> 	switch (si->si_code) {
> 		case POLL_IN: ...; break;
> 		...
> 		case POLL_ERR: ...; break;
> 		case POLL_HUP: ...; break;
> 	}

OK, thanks for explaining.

Gavin