Date: Sun, 21 Nov 2010 14:39:08 +0000 (GMT) From: Gavin Atkinson <gavin@FreeBSD.org> To: Jilles Tjoelker <jilles@stack.nl> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r215572 - stable/8/sys/sys Message-ID: <alpine.LNX.2.00.1011211437200.10869@ury.york.ac.uk> In-Reply-To: <20101121133531.GB17293@stack.nl> References: <201011201646.oAKGkGW7019085@svn.freebsd.org> <alpine.LNX.2.00.1011211241060.2142@ury.york.ac.uk> <20101121133531.GB17293@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 21 Nov 2010, Jilles Tjoelker wrote: > On Sun, Nov 21, 2010 at 12:42:24PM +0000, Gavin Atkinson wrote: > > On Sat, 20 Nov 2010, Jilles Tjoelker wrote: > > > Author: jilles > > > Date: Sat Nov 20 16:46:16 2010 > > > New Revision: 215572 > > > URL: http://svn.freebsd.org/changeset/base/215572 > > > > Log: > > > MFC r215183: Make POLL_ERR and POLL_HUP different. > > > > The kernel currently does not generate any of the POLL_* constants, but > > > some applications use them and break if they are not all distinct. > > > Is this a good idea to merge to a stable branch? Presumably some of those > > same applications will now break due to the constants changing? > > The typical usage appears to be > switch (si->si_code) { > case POLL_IN: ...; break; > ... > case POLL_ERR: ...; break; > case POLL_HUP: ...; break; > } OK, thanks for explaining. Gavin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LNX.2.00.1011211437200.10869>